Comments (12)
Sure! @sculley
from docser.
@kabir0x23 @0xFTW - I am ready to submit a PR which I have tested inside my fork. There is only a tagged release in the releases but we need an actual release as my code relies on the Github API to obtain the latest release (this can't be done with tags)
https://github.com/thecyberworld/docser/releases
I have chosen to build the binary rather than downloading pre-existing binaries as that requires further work to the Github Actions.
Can you please add a v0.1.0 release today to the releases page? as soon as that is ready I can submit my PR.
from docser.
@kabir0x23 @0xFTW - I am ready to submit a PR which I have tested inside my fork. There is only a tagged release in the releases but we need an actual release as my code relies on the Github API to obtain the latest release (this can't be done with tags)
https://github.com/thecyberworld/docser/releases
I have chosen to build the binary rather than downloading pre-existing binaries as that requires further work to the Github Actions.
Can you please add a v0.1.0 release today to the releases page? as soon as that is ready I can submit my PR.
Yes sure, will add by today
Thank you..
from docser.
It's great having you contribute to this project
🌟 Welcome to the community 🌟
- If you would like to continue contributing to open source and would like to do it with an awesome inclusive community.
- You should join our Discord chat and our GitHub Organisation.
- We help and encourage each other to contribute to open source little and often 😄.
- Any questions let us know.
from docser.
Hello @0xFTW I would like to work on this issue to add the ability to upgrade docser
from the application itself. Could you assign this to me?
from docser.
Hi @sculley, is there any update?
from docser.
@0xFTW - I will send a PR over the weekend.
I currently am working on a solution that relies on the releases in GitHub, it checks if the there is a release which is newer than the binary being ran and if so downloads/extracts and then updates the local binary.
What are you thoughts is that the approach you envisioned?
from docser.
So noticed we don't include the binary in the releases, which doesn't work well with my solution.
I was thinking that ideally this docser --upgrade
feature could be used from a built binary but can look into downloading latest code and building on the fly too.
from docser.
So noticed we don't include the binary in the releases, which doesn't work well with my solution.
I was thinking that ideally this
docser --upgrade
feature could be used from a built binary but can look into downloading latest code and building on the fly too.
we can add binaries, i will add by today
do have any another option, or this one is the most optimal solution?
from docser.
@kabir0x23 - I for see two different solutions
Solution 1 - Download/Replace pre-existing Go Binary
Solution 2 - Download/Build/Replace pre-existing Go Binary
I am currently looking into both and will write code for both and test, I feel like Solution 1 would be cleaner but this would require we update the Github Action release workflow to build binaries for all intended platforms/architectures i.e. Windows/Linux/Darwin & AMD64/ARM64 (potentially many more)
Solution 2 wouldn't require any modifications to the Github Actions release workflow but will require more code (I suspect)
What are your thoughts?
from docser.
@kabir0x23 @0xFTW - I have submitted #7 I have written in way so that if it can't find a release in the GitHub release page (which there currently isn't) it will return a message
Unable to find the latest release, exiting.
Which should allow this PR to be reviewed/approved/merged and then once you have time to add the releases it will work.
The change makes use of constants to track the current version and should be updated for all future releases.
const (
owner = "thecyberworld"
repo = "docser"
currentVersion = "v0.1.0"
)
from docser.
@kabir0x23 @0xFTW - I have submitted #7 I have written in way so that if it can't find a release in the GitHub release page (which there currently isn't) it will return a message
Unable to find the latest release, exiting.
Which should allow this PR to be reviewed/approved/merged and then once you have time to add the releases it will work.
The change makes use of constants to track the current version and should be updated for all future releases.
const ( owner = "thecyberworld" repo = "docser" currentVersion = "v0.1.0" )
Hey @sculley
thanks for your contributions, we will review it by today
from docser.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docser.