Comments (10)
https://gist.github.com/melissanoelle/f51a4da688522e16d0bf
from yauzl.
looks like maybe it's somehow an OSX issue. Travis wouldn't catch that.
from yauzl.
The test is complaining that there folder test/success/unicode/Turmion Kätilöt
doesn't exist. Can you post the results of this command?
$ find test/success/unicode/
test/success/unicode/
test/success/unicode/Turmion Kätilöt
test/success/unicode/Turmion Kätilöt/Hoitovirhe
test/success/unicode/Turmion Kätilöt/Hoitovirhe/Rautaketju.mp3
test/success/unicode/Turmion Kätilöt/Pirun nyrkki
test/success/unicode/Turmion Kätilöt/Pirun nyrkki/Mistä veri pakenee.mp3
from yauzl.
here's another thing to try:
$ node -e "var fs=require('fs');console.log(fs.readdirSync('test/success/unicode'))"
[ 'Turmion Kätilöt' ]
from yauzl.
[Thu Oct 16 14:16:07]$ find test/success/unicode
test/success/unicode
test/success/unicode/Turmion Kätilöt
test/success/unicode/Turmion Kätilöt/Hoitovirhe
test/success/unicode/Turmion Kätilöt/Hoitovirhe/Rautaketju.mp3
test/success/unicode/Turmion Kätilöt/Pirun nyrkki
test/success/unicode/Turmion Kätilöt/Pirun nyrkki/Mistä veri pakenee.mp3
[Thu Oct 16 15:03:06]$ node -e "var fs=require('fs');console.log(fs.readdirSync('test/success/unicode'))"
[ 'Turmion Kätilöt' ]
from yauzl.
I've reproduced this error on windows.
from yauzl.
I've reproduced this error on windows.
false alarm. I ran into a different problem.
from yauzl.
Thanks andrewrk and melissanoelle for helping chase this issue down. It turns out unicode file names are spooky on mac. If a file name has an ä
, linux and windows encode it as the unicode "\xc3\xa4"
, which is just the letter ä
. But on mac, ä
is an a
followed by an umlaut: "\x61\xcc\x88"
. Why does mac make this more complicated? Why are there two ways to make the ä
character in unicode? Whatever.
The conclusion is that the test harness can't trust the host file system, since some file systems scramble the bytes of the file names. I'll need to move the test data into the test code so that expected file paths are deterministic.
from yauzl.
@maxogden, could you see if there are still any test failures for you? thanks.
from yauzl.
@thejoshwolfe yep they pass now, thanks!
from yauzl.
Related Issues (20)
- Serialise entry item HOT 4
- Buffer deprecated warning HOT 3
- error : invalid central directory file header signature: 0x5053884e HOT 1
- Unable to unzip hidden files HOT 1
- Unable to open correct Zip64 files with 0xffff as "number of this disk" in eocdr HOT 1
- [Feature Request] Support for AES-256 decryption HOT 1
- bug and workaround when running from win executable created with pkg HOT 1
- invalid comment HOT 1
- How to open password protected zip files HOT 2
- Failure when readstream doesn't have the unpipe method implementation
- calculating progress for the whole archive. HOT 3
- Opening of archive with entry named "/" fails HOT 3
- Invalid signature causes process to close unexpectedly HOT 2
- how to handle different values for extraFieldLength in local file header vs central directory file header HOT 2
- use bigint HOT 1
- Unzipping nested folders from archive HOT 1
- What file types are supported? HOT 1
- end of central directory record signature not found HOT 2
- Uncaught Error: ENOENT: no such file or directory, open xxx file path HOT 1
- Alternative library: yauzl-promise HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yauzl.