Giter Site home page Giter Site logo

Comments (7)

theKashey avatar theKashey commented on May 23, 2024 1

Look like here was a problem - c4baf7b#diff-a7f3a36956272929f3c693c98e5ea8edR12

Fixed in 5.2.3

from react-imported-component.

theKashey avatar theKashey commented on May 23, 2024

Could you elaborate more?

from react-imported-component.

wmertens avatar wmertens commented on May 23, 2024

I tried to do

import React from 'react'
import importedComponent from 'react-imported-component'
import Box from 'components/Layout/Box'

// The list of import mappings
try {
	require('app/imported-components')
} catch (err) {
	console.log('imported-components.js not found')
}

const DefaultLoading = props => <Box {...props}></Box>

export const makeSplitPoint = (fn, options) =>
	importedComponent(fn, {LoadingComponent: DefaultLoading, ...options})

but when I try to use it elsewhere by

import {makeSplitPoint} from 'stuff'
const AsyncComponent = makeSplitPoint(() => import('./SomeComponent'))

const App () = => <AsyncComponent />

, it doesn't actually end up in the marks. I have to import directly from react-imported-component.

from react-imported-component.

theKashey avatar theKashey commented on May 23, 2024

Something is wrong. It was supported from(in?) the beginning.
Let me double check.

from react-imported-component.

wmertens avatar wmertens commented on May 23, 2024

🤔 Hmmm still seems to not work. I'll investigate later today.

from react-imported-component.

wmertens avatar wmertens commented on May 23, 2024

Aha, I had to clear the Babel cache. Works great now! 👍

from react-imported-component.

theKashey avatar theKashey commented on May 23, 2024

:hooray:

from react-imported-component.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.