Can't ride pig

[themoonisacheese]

Can't ride pig

[DarkoGNU]

Lol, something similar happened to me with a horse. I think I haven't tried clicking shift. Dumb me :P

This should have the critical label, ridding animals is a big part of 2b2t, for traveling

[themoonisacheese]

a critical bug would be something like "minecraft crashes on finishing queue". In comparison, this is not that much of an issue. it's still an issue, and i'm investigating it, but it's absolutely not critical.

[Rattlyy]

Minecraft-node-protocol simply doesn't support yet riding entities, so, it simply doesn't work until Prismarine fixes it. Probably will get fixed in decades because they're dead lmao

[themoonisacheese]

that would explain it. I have never seen that in the docs, but I wouldn't be surprised if if one of those undocumented issues.

sadly, this means that this will go unifxed for as long as I keep using minecraft-protocol. It's early for a rewrite, but that would probably fix a bunch of issues (but of course introduce new ones).

[Rattlyy]

If you check flying-squid(mc server framework based on minecraft-protocol) it has the issue of ridable animals.

[Rattlyy]

Same for fishing, good pvp etc

[hazzal]

This appears to be caused by the entityId of the player not being set correctly when connecting through the proxy. The entityId is announced on the packet with the meta name"login", it can be set correctly when creating the clientProxy
And more specifically the issue happens because when the packet set_passenger gets sent from the server since it provides an entityId which is riding the boat/pig/horse, and if the entityId of the player doesn't match the server then the client doesn't understand that it is riding the given entity.

I have made a PR that might fix this issue. I have tested it on another server where the change seems to work. #51

[themoonisacheese]

hopefully fixed with #51