Giter Site home page Giter Site logo

Comments (16)

kojot1234 avatar kojot1234 commented on July 3, 2024 6

@hajekj Would you mind pushing a release out, looks like multiple people are waiting for this. Thanks.

from oauth2-azure.

infabo avatar infabo commented on July 3, 2024 5

Could you please release a new version? Thank you

from oauth2-azure.

10n avatar 10n commented on July 3, 2024 3

I was also suggesting dropping the compatibility, because that may have been the reason for using the 3rd argument.

from oauth2-azure.

10n avatar 10n commented on July 3, 2024 2

Currently the release 2.1.1 has the following dependency "php": "^7.1|^8.0",

https://github.com/TheNetworg/oauth2-azure/blob/v2.1.1/composer.json

My suggestion is to drop entirely firebase/php-jwt": "~3.0||~4.0||~5.0" and only keep compatibility with ^6.0
because older version are not even compatible with PHP 7


"require": {
      "php": ">=5.3.0"
},

https://github.com/firebase/php-jwt/blob/v5.5.1/composer.json

from oauth2-azure.

tomasAl avatar tomasAl commented on July 3, 2024 2

Maybe someone knows when the 2.1.2 version will be released? Thank you

from oauth2-azure.

10n avatar 10n commented on July 3, 2024 1

I have createa a pull request, that 3rd argument is not necessary anymore, the variable $keys already is converted to ann array of \Firebase\JWT\Key

#189

from oauth2-azure.

andrewsauder avatar andrewsauder commented on July 3, 2024 1

I've submitted a PR to get this fixed. #191

from oauth2-azure.

pps1 avatar pps1 commented on July 3, 2024 1

@kojot1234 @hajekj Any news on 2.1.2? We too are running into this issue with firebase/php-jwt:6.8.1 and would prefer not version locking at 6.5.0. Thanks for your support!

from oauth2-azure.

ysipd26020 avatar ysipd26020 commented on July 3, 2024

Hi,

My PHP version is 7.4.x, the version of firebase/php-jwt is the version I'm referring to.

With PHP 7.4 using firebase/php-jwt 6.7.0 with oauth2-azure 2.1.1, I am getting the error due to decoding the JWT
With PHP 7.4 using firebase/php-jwt 6.5.0 with oauth2-azure 2.1.1, I am able to see that the JWT provided by oauth2-azure is decoded by php-jwt.

I would assume that oauth2-azure would need to update its usage of the php-jwt library to support the change introduced in version 6.6.0 and further into 6.7.0

Thanks

from oauth2-azure.

janfejtek avatar janfejtek commented on July 3, 2024

it looks like third argument was used only before php-jwt 5.5 https://github.com/firebase/php-jwt/releases/tag/v5.5.0, so removing it breaks the compatibility with older versions anyway

from oauth2-azure.

casey977 avatar casey977 commented on July 3, 2024

Any news on this?

from oauth2-azure.

kojot1234 avatar kojot1234 commented on July 3, 2024

@casey977 If I remember correctly this has been resolved already and issue can be closed.

from oauth2-azure.

casey977 avatar casey977 commented on July 3, 2024

@casey977 If I remember correctly this has been resolved already and issue can be closed.

Well, I'm here because I get the error...

from oauth2-azure.

lyrixx avatar lyrixx commented on July 3, 2024

@casey977 what version are you using?

from oauth2-azure.

casey977 avatar casey977 commented on July 3, 2024

@casey977 what version are you using?

I use Laravel 10.46.0

from oauth2-azure.

lyrixx avatar lyrixx commented on July 3, 2024

what version of this lib. You can find it with composer show thenetworg/oauth2-azure

from oauth2-azure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.