Comments (4)
Thanks @royalh23, @TheOdinProject/html-css can we get you're input on this one please?
from curriculum.
I think it makes sense to use a transform there instead.
Technically, transform: scale(2)
is a little different in that it'll just scale the element itself, including border size, whereas animating the width/height will only change the space taken up by the element as a whole (regardless of box-sizing).
Don't think that's a differentiation that's important to include, and I can't think of many cases with that kind of animation where you'd purposely want to just change the width/height and not just scale the whole thing. Since the lesson says we have also specified that the ball double in **size.**
, we should be fine to just replace the relevant code.
The codepen will need to be changed accordingly as well.
from curriculum.
Going to assign you @royalh23. I think changing the height/width adjustment to simply transform: scale(2);
makes much more sense here (esp. since we've already covered transforms).
We will handle the codepen on our side so both parts are changed at roughly the same time.
from curriculum.
@MaoShizhong Gotcha. Will make a PR tomorrow
from curriculum.
Related Issues (20)
- Ruby on Rails: Final project links to paperclip-cloudinary which relies on the deprecated paperclip gem HOT 6
- NodeJS: new updated crash course video of TraversyMedia can replace old video link HOT 2
- Project: Memory Card: Instruct learners to use useEffect explicitly HOT 8
- DOM Manipulation and Events: More clearly describe the relationship between nodes and elements. HOT 4
- Factory Functions and the Module Pattern: The link for additional resource to the interactive scrim on factory functions should be changed HOT 3
- Working with External APIs: Add Mention of OmniAuth Via Devise HOT 1
- Form Basics: Include image examples
- Bug: Broken link HOT 3
- JavaScript Course: Adding note about template literals on import statements HOT 3
- Ruby On Rails: Problem in Knowledge Check of Routing Lesson. Postman Chrome extension is deprecated HOT 5
- Javascript Course: Constructors Are Bad For JavaScript should be removed from assignments HOT 2
- nodeJS: More Detailed Explanation in 'Routes and Controllers' Lesson HOT 1
- nodeJS/authentication: missing an important middleware function , app.use(passport.initialize())
- The Asset Pipeline: <learning overview item with no reference in lesson> HOT 1
- Techniques: <most of the external links refuses to load> HOT 3
- Testing Basics: Broken link: "Read about the basic process and the benefits of TDD." HOT 1
- Command Line Basics: Remove Assignment & Additional Resource Items HOT 4
- Intermediate HTML and CSS Course: Link to previous lesson is under the Ruby path instead of Javascript path HOT 1
- Installing Node.js: <Short description of your suggestion> HOT 3
- Links and Images: broken link HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from curriculum.