Giter Site home page Giter Site logo

Comments (10)

scheals avatar scheals commented on September 2, 2024

I don't remember what my intention was with that Project Management bit and whether 3.2.2 was chosen because that's what I was used to running when going through the curriculum or just the first version that came into my head.

It's supposed to be an example, a version you could declare, not the one you necessarily have to declare.

It actually makes sense that your local version would differ from the globally used one. Since the problem on Discord was not connecting the fact that declaring a version requires you to have that version installed, I'd probably tackle it from another angle - perhaps by elaborating:

You can do it easily by for example running rbenv local 3.2.2 as it creates a .ruby-version file with the version declared - 3.2.2. Test the command out by using one of your rbenv installed Ruby verisons.

This would save on the necessity of changing Ruby version when curriculum changes the one it expects and perhaps make it clear that it does not matter what version is declared.

from curriculum.

MaoShizhong avatar MaoShizhong commented on September 2, 2024

Possibly related - would it be worth updating theodinproject's repo wiki to be version agnostic as well for what it currently has as rbenv local 3.2.2?

from curriculum.

dellaighted avatar dellaighted commented on September 2, 2024

Why not put the downloads page for ruby in the lesson and have students checkout what the latest version is before running the commands in the lesson? The version number is always changing so we can just say check the Ruby Downloads page to find the latest version 3.x.x (this is the version number you will be using in the commands in the following steps). Writing 3.x.x is more generic, and I think most people would understand that it's a placeholder for some version.

I would like to work on this issue!

from curriculum.

JoshDevHub avatar JoshDevHub commented on September 2, 2024

I don't remember what my intention was with that Project Management bit and whether 3.2.2 was chosen because that's what I was used to running when going through the curriculum or just the first version that came into my head.

It's supposed to be an example, a version you could declare, not the one you necessarily have to declare.

It actually makes sense that your local version would differ from the globally used one. Since the problem on Discord was not connecting the fact that declaring a version requires you to have that version installed, I'd probably tackle it from another angle - perhaps by elaborating:

You can do it easily by for example running rbenv local 3.2.2 as it creates a .ruby-version file with the version declared - 3.2.2. Test the command out by using one of your rbenv installed Ruby verisons.

This would save on the necessity of changing Ruby version when curriculum changes the one it expects and perhaps make it clear that it does not matter what version is declared.

I think this idea is probably better than what I wrote above, but I also think it'd be nice to just give learners the command to list out their rbenv installed ruby versions.

So maybe have it be something like:

You can do it easily by for example running rbenv local 3.2.2 as it creates a .ruby-version file with the version declared - 3.2.2. Test the command out by using one of your rbenv installed Ruby versions. Run rbenv versions to see the list of Ruby versions you have installed.

Does that seem okay? @scheals

from curriculum.

JoshDevHub avatar JoshDevHub commented on September 2, 2024

Possibly related - would it be worth updating theodinproject's repo wiki to be version agnostic as well for what it currently has as rbenv local 3.2.2?

@MaoShizhong Yeah we can definitely do something with that. I'd probably advocate changing this to tell users to run the command with the version named in the .ruby-version file in the root of the repo: https://github.com/TheOdinProject/theodinproject/blob/main/.ruby-version -- that file is the authority on the version of Ruby being used by the main app.

Why not put the downloads page for ruby in the lesson and have students checkout what the latest version is before running the commands in the lesson? The version number is always changing so we can just say check the Ruby Downloads page to find the latest version 3.x.x (this is the version number you will be using in the commands in the following steps). Writing 3.x.x is more generic, and I think most people would understand that it's a placeholder for some version.

I would like to work on this issue!

This is another good idea @dellaighted. I probably slightly prefer what I have above with Scheals about listing out versions and using one. Teaches people that they can set the local to any of their installed versions and conveys more useful information about rbenv, while also being flexible and future-proofed against future version changes.

As soon as I get the go-ahead on what I wrote above from scheals, I'll assign this to you. Thank you for volunteering!

from curriculum.

MaoShizhong avatar MaoShizhong commented on September 2, 2024

@JoshDevHub awesome, I'll leave that bit with you then since you know better about me on that.

from curriculum.

scheals avatar scheals commented on September 2, 2024

@JoshDevHub
Superb!

from curriculum.

JoshDevHub avatar JoshDevHub commented on September 2, 2024

Awesome!

I'll assign you @dellaighted . Adjusted the acceptance criteria to the new plan on the Project Management lesson. Let me know if you have any questions 👍

from curriculum.

dellaighted avatar dellaighted commented on September 2, 2024

Just to be clear @JoshDevHub am I also doing the first part of the acceptance criteria (i.e. the Installing Ruby lesson)? Should I change the 3.3.0 to 3.3.4 or 3.x.x as I mentioned in my earlier comment? I'll work on the changes in the Project Management lesson in the meantime.

from curriculum.

JoshDevHub avatar JoshDevHub commented on September 2, 2024

Just to be clear @JoshDevHub am I also doing the first part of the acceptance criteria (i.e. the Installing Ruby lesson)? Should I change the 3.3.0 to 3.3.4 or 3.x.x as I mentioned in my earlier comment? I'll work on the changes in the Project Management lesson in the meantime.

In the Installing Ruby lesson, change all references to the Ruby version to 3.3.4 (replacing 3.3.0).

from curriculum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.