Giter Site home page Giter Site logo

Comments (3)

harningle avatar harningle commented on June 11, 2024

Can reproduce in version 3.1.6. Seems we forgot to include CountryCode when fixing #460:

Fast-F1/fastf1/_api.py

Lines 1493 to 1496 in 89033fd

default_keys = [
'RacingNumber', 'BroadcastName', 'FullName', 'Tla', 'Line', 'TeamName',
'TeamColour', 'FirstName', 'LastName', 'Reference', 'HeadshotUrl'
]

@theOehrly fastf1/_api.py in master branch doesn't fix #460. Shall I wrap up both #460 and this and create a PR to master?

from fast-f1.

harningle avatar harningle commented on June 11, 2024

A quick fix would be go to _api.py, and add , 'CountryCode' to line 1495. You can find your _api.py by running pip show fastf1 in terminal:

Name: fastf1
Version: 3.1.6
Summary: Wrapper library for F1 data and telemetry API with additional data processing capabilities.
Home-page: https://github.com/theOehrly/Fast-F1
Author: Oehrly
Author-email: [email protected]
License: MIT
Location: c:\program files\python310\lib\site-packages  <-- here

Open c:/program files/python310/lib/site-packages/fastf1/_api.py and change line 1495 to:

    default_keys = [
        'RacingNumber', 'BroadcastName', 'FullName', 'Tla', 'Line', 'TeamName',
        'TeamColour', 'FirstName', 'LastName', 'Reference', 'HeadshotUrl', 'CountryCode'
    ]

from fast-f1.

theOehrly avatar theOehrly commented on June 11, 2024

@harningle Thanks for looking into this. If you want to create a PR to fix this, the best way would be to check out the maintenance-v3.1 branch, commit the fix and submit the PR from there. Then, change the base branch of the PR from master to maintenance-v3.1 in Github.

maintenance-v3.1 will be merged into master again at some point. That wasn't very clean branch management from my side. I really should only fix issues on the master branch and backport to the maintenance branch. I need to be more consistent here in the future (meaning from v3.2 onwards).

from fast-f1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.