URL Encode filenames

[thephpleague]

URL Encode filenames

[frankdejonge]

Corrected that.

[frankdejonge]

@PatrickRose this should probably be handled within the adapter.

[frankdejonge]

@PatrickRose which kind of url encoding do they require here? urlencode or rawurlencode? Do you have the link to the docs?

[PatrickRose]

I'm using rawurlencode (though I can't remember why offhand) Docs have a notice here

[frankdejonge]

@PatrickRose the docs say we should be using urlencode, I'll use that for all the segments, commit incoming.

[PatrickRose]

Ahh, I remember why. Guzzle under the hood replaces ' ' with '%20'. We spotted this after we'd been using it for a while so we needed to keep the filenames the same. Would it be possible to use rawurlencode?

[frankdejonge]

@PatrickRose does it matter that it does it? because urlencode replaces it with + so Guzzle can't replace it anymore.

[PatrickRose]

It's a definite BC break, because previously $filesystem->exists('some file') would return true, and with urlencode it wouldn't.

[frankdejonge]

ah, so it actually SHOULD be rawurlencode.

[PatrickRose]

I think there's a minor BC break as part of this, so not sure how you want to handle it (I believe it's cases like $filesystem->put('some#file') actually wrote to 'some')

[frankdejonge]

@PatrickRose ~_^

[PatrickRose]

Sorry <3

I think it's okay - it's rare that people have those in their file names, which was something I had to deal with because users.

[frankdejonge]