Giter Site home page Giter Site logo

Support phpunit 5 about slim-test-helpers HOT 7 CLOSED

there4 avatar there4 commented on September 22, 2024
Support phpunit 5

from slim-test-helpers.

Comments (7)

craig-davis avatar craig-davis commented on September 22, 2024

Hi,

Thanks for checkout out this project. Currently, we're pinned to PhpUnit 4.*. I don't personally have time to investigate this change, but I would welcome a PR or new contributor to work on this.

If you've got some time, this would probably be a welcome contribution.

Sidenote - because this project is about unit testing Slim2, and we haven't address Slim3, I do somewhat consider this project to no longer be under active development.

from slim-test-helpers.

khrizt avatar khrizt commented on September 22, 2024

I'll take a look, any particular reason for being pinned to phpunit 4.*? So I have something to start investigating

from slim-test-helpers.

craig-davis avatar craig-davis commented on September 22, 2024

any particular reason

This project predates the release of PHPUnit 5, and I never found the new feature set compelling enough to upgrade. But, it would be a welcome addition!

from slim-test-helpers.

khrizt avatar khrizt commented on September 22, 2024

I've cloned the project, updated dependencies of both phpunit (to 5.) and dbunit (to 2.) and the tests pass OK. Also I've forked you library and added in my project, also my unit tests passed too. Is there anything else that I should try? If not I can make a PR

from slim-test-helpers.

craig-davis avatar craig-davis commented on September 22, 2024

That sounds very thorough, and exciting. Make a PR and let's it going!

from slim-test-helpers.

khrizt avatar khrizt commented on September 22, 2024

I've made the PR #30 but looks like php version inferior to 5.6 should be deprecated because phpunit 5 only support 5.6+. What do you think?

from slim-test-helpers.

craig-davis avatar craig-davis commented on September 22, 2024

This has made it to the new V3 master branch:
https://github.com/there4/slim-test-helpers/blob/master/composer.json#L24

from slim-test-helpers.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.