Why are we generating the uid?

[reinierkors]

Why are we generating the uid?

[therecluse26]

Huh, interesting! I hadn't thought of that method when I wrote it. Thanks
for the tip, I may integrate that in the future :)

On Sat, Sep 24, 2016 at 4:37 PM, Reinier Kors [email protected]
wrote:

Thanks for your response.

I now understand why you added it after digging a bit through the source
code 😄

Although, for my suggestion, you wouldn't even have to add another select
query:

In PDO you can use: PDO::lastInsertId
or for MySQLi you can use mysqli_insert_id();

That's why I said it was unnecessary.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#35 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH24Ao-7T1spPXhS674lbRTVKk7wWT2Nks5qtYoXgaJpZM4KErji
.

• bradley david

[therecluse26]

There are a few reasons. Primarily, I chose to go this direction because of
the application logic with sending verification emails to avoid unnecessary
database calls. When the user signs up and gets a valid response back from
the server, it then automatically sends an email to the user for
self-verification which is done using this user id. If we generated the ID
at the database level, we would have to then build an additional select
statement in the middle in order to pull out the new ID for this. Building
the GUID generation step into the PHP code simplifies this. It is
extremely unlikely that you would ever run into a collision, especially
for something like user ids.

If you are still concerned about it, you can either switch the second
option in the uniqid() function to true, which would increase the entropy
of the unique identifier from 13 characters to 23 (there will be a slight
performance impact, but this would be very minimal), or you could add the
functionality on the database end like you said and simply create an
additional select statement within the logic to pull that new ID out to
send for verification. This would create even more processing overhead
though, which is another reason I wouldn't recommend it.

On Fri, Sep 23, 2016 at 3:20 AM, xDiglett [email protected] wrote:

Why are we not auto incrementing the id in the database, but instead,
generating a uniqid.

uniqid does not guarantee uniqueness of return value, and seems
unnecessary in this case.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#35, or mute the thread
https://github.com/notifications/unsubscribe-auth/AH24AjLKhf9bevHZ9bsMgRqhoT5fg1U0ks5qs328gaJpZM4KErji
.

• bradley david

[reinierkors]

Thanks for your response.

I now understand why you added it after digging a bit through the source code 😄

Although, for my suggestion, you wouldn't even have to add another select query:

In PDO you can use: PDO::lastInsertId
or for MySQLi you can use mysqli_insert_id();

That's why I said it was unnecessary.