Theseus fails to boot if built on non-English locale

[YtvwlD]

Theseus fails to boot if built on non-English locale

[kevinaboos]

Thanks for the report! Yeah, looks like it's related to #425 indeed, but I have no idea why we need a particular locale for the build system to work.

I tried setting LC_ALL="en_US.UTF-8" LANG="en_US.UTF-8" (from de_DE.UTF-8) and it actually worked.

How exactly do you set this, as an environment variable before running make? If so, perhaps we can just force it in the Makefile as a temporary workaround.

[YtvwlD]

yes, I'm running LC_ALL="en_US.UTF-8" LANG="en_US.UTF-8" make run

[kevinaboos]

As someone unfamiliar with other locales, would it be problematic for any reason if we just directly set those env vars in our Makefile?

If that's ok, would you be interested in submitting a PR to do that? If not, no worries. I'm happy to make the change myself.

[YtvwlD]

It would lead to all output being in English (including numbers), but I guess anyone able to understand the README should be fine with this. Also, qemu and cargo aren't even translated. It's mostly make and git that change.

A technical problem could be that the specific locale might not be installed. I've tried LC_ALL="C.UTF-8" with a clean clone and it also works. AFAIK this is available on all modern glibc systems.

I'll try to get a PR ready tomorrow. :)

[kevinaboos]

Ah, interesting. I have never used another locale so I just wanted to be sure it wouldn't have significant (negative) implications for the user if we forced a locale temporarily.

I guess anyone able to understand the README should be fine with this

Hope so! 😄 It'd be great to have some internationalization support but that's likely best left for a future date where things are more stable. Maybe one day!

I've tried LC_ALL="C.UTF-8" with a clean clone and it also works. AFAIK this is available on all modern glibc systems.

I'll try to get a PR ready tomorrow. :)

nice, thanks! no rush.