Segfault while adding files

[thewisenoob]

Segfault while adding files

[aladar42]

Okay, I tried a few more albums and it seems it's only happening with some, not all of them. Can't find anything that would be wrong with the ones that cause it, though.

[aladar42]

Just a regular 320 kbps MP3, nothing weird about it, all the other players handle it normally...

[aladar42]

I'm not sure how to check if it's damaged, but it plays just fine in LineageOS' default music player, VLC on Android, foobar2000 and Deadbeef on Linux, so I think it's fine. I would upload the file, but I assume that would consist a copyright violation.

The program is still pre-alpha, so issues like this are expected.

That's why I'm reporting the bugs, trying to help out as best as I can. :)

[aladar42]

I can't find your email. :)

edit: I'm an idiot and misread the post. Yeah, I know, you literally gave me the mail. sorry.

[aladar42]

Oh, I sent you a wrong file, it was supposed to be track 6, not 4. :) I assume that the bug is the same though, so I'll just try again in 0.0.7. Thanks. :)

[aladar42]

No problem, happy to help. I'll let you know when the update lands. :)

[aladar42]

Hey, thanks, the files in questions aren't crashing anymore. :) I'll close this issue and let you know if I ever find something else.

[TheWiseNoob]

Adding by folder is not supported yet, but it will be present by 0.2. What kind of audio file were you adding?

[TheWiseNoob]

That's weird because mp3s have been working fine for me. I'll look into testing more of them. If any of those mp3s are damaged, it could be that. I need to fix a bug with damaged files. The program is still pre-alpha, so issues like this are expected.

[TheWiseNoob]

Thanks. I really appreciate the help. If you want to email me a link to it on your Google Drive, Dropbox, or anything similar, my gmail email account is the same as my username here. I will definitely test it myself if you send a file you've confirmed as problematic.

[TheWiseNoob]

I've fixed the bug that causes the second file you sent me to crash OMP when it failed to read the file properly. I'll release the fix later next month with version 0.0.7. I need to fix another bug that is causing that file to not be read properly too.

The first file, Build by Cubanate, is playing fine for me. Was it crashing OMP for you?

I'll be working on this more tomorrow.

[TheWiseNoob]

I'm pretty sure I've solved the problem. The problematic file you sent me opens properly for me now and plays. I'll keep this Issue open until you have a chance to test the fix on more of your collection. This will be included in the 0.0.7 update that will be released sometime on March 18th, 2018.

Thanks for the helpful bug report!

[TheWiseNoob]

Please let me know if today's update fixed this problem or not!

[TheWiseNoob]

Thanks for testing it for me!