gpick packaging - lemon and amalgamation

[thezbyg]

gpick packaging - lemon and amalgamation

[thezbyg]

Comment #1 originally posted by thezbyg on 2011-05-06T11:22:20.000Z:

<empty>

[thezbyg]

Comment #2 originally posted by thezbyg on 2011-05-07T17:07:32.000Z:

Option 2 implemented (revision dd5dabd2ef)
Attached updated source tarball, if all is well I will release new Gpick version next week

[thezbyg]

Comment #3 originally posted by thezbyg on 2011-05-07T17:32:38.000Z:

Hi,

The build process is perfect and works fine with this tarball. There's a tiny itch though, our build process runs a parser on the compiler output in the end and if something 'weird' happens it blocks the build process. This tarball poped an error:

I: Program returns random data in a function
E: gpick no-return-in-nonvoid-function source/uiListPalette.cpp:74

I can fix this by either entering the missing return or eventually by changing it to void (instead of boolean), though I'm not really sure on the impact as I haven't audited the code. I thought it was worth mentioning this to you for the next release :)

For the request change, it's working great, I look forward for the release, so I can submit then the package to Factory for openSUSE 12.1. On my test repository I've also made builds for Fedora 14. So if you want to point Fedora users to my test repo it's available. I've asked Nicu (Fedora design team member) to give it a ride and the feedback is positive, he even wrote a small article about it[1], and I've wrotten another for openSUSE News[2].

Thanks for your nice work on this and for caring with downstreamers :)

[1] - http://nicubunu.blogspot.com/2011/05/color-choosers.html
[2] - http://lizards.opensuse.org/2011/05/05/gpick-an-advanced-color-picker/

Looking forward for the next release,

Nelson

[thezbyg]

Comment #4 originally posted by thezbyg on 2011-05-07T17:47:01.000Z:

Not sure if this is the right way to fix it (I really suck at coding) :)
But nothing strange seems to happen while using gpick.

[thezbyg]

Comment #5 originally posted by thezbyg on 2011-05-07T18:14:52.000Z:

I was taking a look at the Ubuntu/Debian packaging and they have two minor patches to fix the expat linking. Since you are going to release a new update soon, it would probably be helpful to have this ones also included, please take a look at packaging on Ubuntu for this 2 patches:

• 01_expat_dependency.patch
• 02_dsolink_expat.patch

Also the licensing from this package should be: BSD, Expat and LUA Licence. If this is not correct please point me to the correct one.

[1] - https://launchpad.net/ubuntu/+source/gpick/0.2.3-1

[thezbyg]

Comment #6 originally posted by thezbyg on 2011-05-07T19:14:15.000Z:

Fixed the no-return-in-nonvoid-function bug, the return value doesn't matter at the moment, but could in the future (thanks for the patch, it proves that you do not suck at coding :).

Made some changes based on the Ubuntu/Debian patches, a simple variable definition should now be enough to disable internal Expat library usage.

You missed one license, the color name list has it's own license, which looks like some kind of modified BSD license. The list of licenses can be found here http://packages.debian.org/changelogs/pool/main/g/gpick/gpick_0.2.3-1/copyright

[thezbyg]

Comment #7 originally posted by thezbyg on 2011-05-07T20:06:31.000Z:

Awesome, I look forward for the next release. I've fixed the Licensing on my package and included the file you pointed on the documentation for gpick. Now everything should be in place!

By the way you can see my gpick project here where I will maintain it for openSUSE and Fedora (if you have someone looking for packages for RHEL, CentOS or Mandriva I don't mind enabling builds for them as well, just let me know).

https://build.opensuse.org/project/show?project=home:ketheriel:gpick

One more time, thanks,

Nelson

[thezbyg]

Comment #8 originally posted by thezbyg on 2011-05-16T19:13:13.000Z:

Updated to new release... All went great... awesome job.
By the way if this is helpfull, tested with GCC4.6, no issues.

Feel free to close this ticket.

[thezbyg]

Comment #9 originally posted by thezbyg on 2011-05-17T09:17:56.000Z:

<empty>