std::bad_alloc crash for certain windows users.

[thezoc]

std::bad_alloc crash for certain windows users.

[TheZoc]

Hello @sdhawk !

I'll be happy to assist you privately!

I can be reached on Twitter (@zoc) through direct messages. If you don't use twitter, let me know and we will get another way to get in touch.

Cheers!

[sdhawk]

Thanks!

Out of curiosity I had one of the error users try it with a 32-bit version and we finally got log output from it:

Writing File: ./py/map/state/new_round.py
Undefined operation (37) requested for file ª‡MK�í�ñŸÂo (garbage characters continue)

So it seems like somewhere in the decompression process (or perhaps elsewhere) the position in the file is getting thrown off due to some system-specific factor (probably sizes?). I'll continue poking at it and let you know if I isolate the problem.

[sdhawk]

After a whole lot of frustration it became apparent that the only possible thing that could be throwing off the file position would be the fseek/ftell functions themselves. It turns out that this is a very specific issue with the Windows 8.1 SDK that has been fixed in more recent updates of Windows 10, hence the inconsistency in who it affected. You can read the full details here: https://social.msdn.microsoft.com/Forums/Lync/en-US/8c4d27db-1128-4803-951b-fef515455a03/vs2015-non-accurate-fseekfread-operation?forum=vcgeneral

Changing the target platform version to 10.0.16299.0 wasn't enough, I had to also include the Win10 sdk UCRT dlls to fix it for affected users (presumably a fixed vs redistributable for 2017 might eventually fix this in the future?).

So not really a problem with ZPatcher itself, in the end. You can close this.