Giter Site home page Giter Site logo

Comments (4)

postspectacular avatar postspectacular commented on July 23, 2024 2

Hi @respatialized - thank you so much for taking the time to create such a detailed issue & proposal to extend that current (half-baked) functionality! Most (if not all) of these things mentioned are already addressed by the newer TypeScript version of this library (not really the same, more of a rewrite) and should be pretty trivial to port to Clojure:

https://github.com/thi-ng/umbrella/blob/develop/packages/geom/src/path-from-svg.ts

That path parser implementation (~150 lines) too has no extra dependencies other than some constants, small utils and various vector ops (the latter should all be avail in the Clojure version too), all from the same thi.ng/umbrella monorepo:

I'd maybe start with this. The parser is currently undocumented (can prioritize that if it'd help you to get started), but it's been used in production since 2019 and was tested this with hundreds of SVG production files created by different tools (Illustrator, Inkscape, svgo optimizer, handwritten files, W3C)... FWIW I too started with a BNF, but had lots of issues dealing with most of the optimized SVG files and so ended up with this handwritten parser instead...

from geom.

respatialized avatar respatialized commented on July 23, 2024 1

Great, thanks for pointing me in the right direction! I definitely have more than enough to go on now.

from geom.

respatialized avatar respatialized commented on July 23, 2024

@postspectacular One question/clarification before I refine a concrete implementation further: the current implementation of parse-svg-coords is lazy, yielding a sequence of segments. For API compatibility, I assume this means that my new implementation should also be lazy, correct?

from geom.

respatialized avatar respatialized commented on July 23, 2024

@postspectacular I have a draft PR that implements more complete parsing of SVG paths, but I think there are a few unresolved questions about scope that I would appreciate some thoughts on!

#98

from geom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.