'This address is not yours.' error during OPC guest checkout and Registration process type 'Only account creation'

[therampagerado]

'This address is not yours.' error during OPC guest checkout and Registration process type 'Only account creation'

[getdatakick]

This is regression caused by commit c54a494.

@eschiendorfer Emanuel, looks like this strange ajax restriction was meant for instant checkout. Do you remember why it was removed? Did it prevented some other functionality from working properly? Should we revert?

[getdatakick]

Fixed by reverting the original commit.

[eschiendorfer]

Sorry @getdatakick I was not so much into coding recent weeks. I have completly overseen this.

I am quite sure, that I had issues, since I submit a lot of forms with ajax. IMO this restriction is very dubious. But I understand ofc that it needed to be reverted for now. I will make an override on my side (as a quick solution).

Edit: I have now shortly looked into the code. But this is just a big mess (or spaghetti code as dekker used to call it) right? I have the impression that: Instant checkout means two calls proccessSubmitAccount(). First call probably without ajax and second (for address) with ajax. Is that correct? And instead of using different submitNames its seperated by !$this->ajax.

IMO addresses should be saved by "submitAddress". No matter if it's done in instant checkout or in Address front controller.

If I am wrong, let me know. I don't think there is a simple and clean solution as this is also theme related.

Edit 2: I am even more confused as I can't find an $address->save() or $address->add() in processSubmitAccount().