Library review

[millerlogic]

Library review

[slingamn]

I addressed most of this in my fork: https://github.com/goshuirc/irc-go/tree/master/ircevent

1. Fixed issue with capability negotiation on reconnection
2. Fixed synchronization of nickcurrent, AcknowledgedCaps, etc.
3. Fixed callback ID reuse
4. Fixed the context cancellation issue by removing support for callback timeouts and concurrent execution of callbacks (my thinking was that it's not safe for callbacks to take macroscopic time anyway --- slow handlers should be moved to separate goroutines, either with go or with a queue system)
5. CTCP support: not fixed (I disabled CTCP support by default; however, I would consider making the change described above)
6. Encoding support was removed (the new API exposes raw bytes only)

Some additional changes:

1. Support for parsing 005 RPL_ISUPPORT
2. Support for IRCv3 CAP version 302, including parsing capability values
3. Support for IRCv3 batch and labeled-response
4. Fixed the deadlock from #131
5. Fixed the injection issues from #127 (the message library is now very aggressive about refusing to emit invalid IRC lines; escaping/replacing is still left up to the caller though)

[IceflowRE]

Maybe do some PRs regarding some issues to this library?

[slingamn]

Apart from the issues that were covered by #132, I don't think I can. I rewrote parts of the library line-by-line, changed the API, integrated the other irc-go libraries (in particular the message parser/assembler) and in general made incompatible changes.

I understand that this might be a breach of etiquette, but for most use cases I would recommend that people simply switch to using the fork. The issues with the original codebase are fairly deep and it's challenging to fix them "in place" with a series of scope-limited patches.