Comments (3)
Yes this is unfortunate. But we cannot break ABI/API.
I think in the library you will find several places where the types mismatch. I close this issue because changing API is much more painful then the type mismatch.
Does this cause you any actual problems, beside being aesthetically wrong? Then please reopen or send a patch/pullrequest (but again, we cannot change API, we can only add new API with fixed behavior).
Thank you!!
from libnl.
I have changed sources in a way that will NOT break API and ABI. This mean transitions int
-> unit32_t
and so on, and that will not break something because sizeof()
is equal and values are actually positive in normal cases.
Please reopen if you agree.
from libnl.
I think int -> uint32_t is an ABI change. In C, the size of an int is not fixed and libnl is supposed to work also on systems where an int is not 32 bits -- well, maybe there are bugs and it doesn't work because of lack of testing. But it should work.
While it might work on my system/compiler, I am not confident that it will work on other systems. That's why I rather not change it.
I didn't reject #83 as a whole, but several changes do IMO change ABI/API.
For example, not OK:
int *
-> unsigned int *
unsigned int
-> uint32_t
OK:
uint8_t *
-> const void *
uint8_t *
-> const uint8_t *
from libnl.
Related Issues (20)
- CVE-2022-20385 HOT 7
- Implement LWTUNNEL_ENCAP_SEG6_LOCAL
- Remove affected routes from cache on interface down? HOT 1
- TC action stats are not updated HOT 1
- The delete command does not take effect.
- xfrm lib missing the set/get for if_id
- Warnings about missing symbol when building with mold linker HOT 11
- Get all SP policies
- Zero counter IPCTNL_MSG_CT_GET_CTRZERO while listing does not work HOT 2
- Build failed HOT 2
- Is the comment for nl_nh_group_info correct? HOT 2
- InvalidFree and InvalidRead in Valgrind when linked against libnl HOT 3
- libnl-3.8.0 fails checks HOT 6
- need help with rtnl_route_add without gateway but a subnet HOT 3
- need help about rtnl_route_nh_set_via HOT 1
- support linux altname
- error: storage size of 'tm_buf' isn't known due to missing #include <time.h> HOT 1
- 2nd RTM_NEWLINK notification with operstate down is always 1 second delayed HOT 3
- Question: how are multiple VLANs in a bridge with VLAN filtering mode represented
- bridge object in link cache may get replaced by an incomplete object HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libnl.