Can't make it work

[thom4parisot]

Can't make it work

[thom4parisot]

Hey @kingio,

I'm sorry to read you have some hard time making it work. Let's try to fix this together 🙂

I see you try to load the content of the ./build directory. Is it the one which contains your extension manifest.json file? Or is it the location you want to store the compiled extension to?
If you aim load() at the directory which contains your extension, it should work.

generateUpdateXML can be called only after load happened so it has to be somewhere in the chain of promises. It is not the source of your problem I suppose.

If the source code of your extension is on GitHub and the pointers I just wrote did not help, feel free to share your repo so as we can have a look at it.

[kingio]

Yes, manifest was inside build directory.
I ended hardcoding the public key in your code to build the crx.

[reyoucat]

archive
        .glob(selfie.src, {
          cwd: selfie.path,
          matchBase: true,
          ignore: ['node_modules/**', '*.pem', '.git', '*.crx']
        })
        .finalize();

maybe, ignoring the folder will resolve it. (node_modules/**)

[msakamoto-sf]

@kingio me too, same problem.

debugging with vscode, I found program abort at this line:
https://github.com/oncletom/crx/blob/master/src/crx.js#L96

 load: function (path) {
    var selfie = this;

    return resolve(path || selfie.rootDirectory)
      .then(function(metadata){
        selfie.path = metadata.path;
        selfie.src = metadata.src;

        selfie.manifest = require(join(selfie.path, "manifest.json"));
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I tried this tiny script: ( ./dist/chrome/manifest.json existed.)

const manifest = require(path.join('./dist/chrome/', 'manifest.json'))

this result:

module.js:538
    throw err;
    ^

Error: Cannot find module 'dist\chrome\manifest.json'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
...

but const manifest = require('./dist/chrome/manifest.json') works correctly (success to json read).

[msakamoto-sf]

I think this problem re-produce only at windows platform.

[msakamoto-sf]

path.join('./dist/chrome/', 'manifest.json') on windows generates dist\chrome\manifest.json.
->
const manifest = require('./dist/chrome/manifest.json') successed,
<>
const manifest = require('dist\\chrome\\manifest.json') failed.

this may be node.js require() bug on windows platform.

[msakamoto-sf]

This works on Windows10 Pro 64bit, node.js v8.9.1

function monkeyPatchedResolve (path) {
  return new Promise(function (resolve, reject) {
    return resolve({
      path: path,
      src: '**'
    })
  })
}

crx.load = (path) => {
  var selfie = crx
  return monkeyPatchedResolve(path || selfie.rootDirectory)
    .then(function (metadata) {
      selfie.path = metadata.path
      selfie.src = metadata.src
      selfie.manifest = require(selfie.path + '/manifest.json')
      selfie.loaded = true
      return selfie
    })
}
crx.load('./dist/chrome') // WARNING : './' NEEDED !!
  .then(() => {
    return crx.loadContents()
  })
  .then((zipBuffer) => {
    fs.writeFile(`build/my-ext.chrome.zip`)
    return crx.pack(zipBuffer)
  })
  .then(crxBuffer => {
    const updateXML = crx.generateUpdateXML()
    fs.writeFile(`build/chrome-update.xml`, updateXML)
    fs.writeFile(`build/my-ext.crx`, crxBuffer)
    console.log('chrome packaging done.')
  })

Good Luck !!

[thom4parisot]

Sorry for being late in the game.

I have setup a Windows build in the PR #76. But I struggle to reproduce the problem on any version of Node on Windows. Could it be related to the version of Windows too? We can build on Windows Server 2012 R2 or Windows Server 2016.

Let me know, I'd be happy to see this one fixed.