Giter Site home page Giter Site logo

Comments (5)

thomasclaudiushuber avatar thomasclaudiushuber commented on May 24, 2024

Hi @khaledafifi , sorry, I was on holidays.

You're missing the public access modifier here. Private members are not visible in subclasses. Should be

class A : MvvmGen.ViewModel.ViewModelBase
{
public string id{get; set;}
public string Name{get; set;}
}

class B : A
{
public string Email {get; set; }
}

Please let me know if this works for you.

from mvvmgen.

khaledafifi avatar khaledafifi commented on May 24, 2024

the same result .. the generated vm publish prosperities only from the derived class not the base.
please try yourself.
thanks to your great project.

from mvvmgen.

thomasclaudiushuber avatar thomasclaudiushuber commented on May 24, 2024

Hi @khaledafifi ,

I tried it. I defined these ViewModels

namespace MyViewModels
{
  [ViewModel]
  public partial class A : ViewModelBase
  {
    [Property]
    private string id;

    [Property]
    private string name;
  }

  [ViewModel]
  public partial class B : A
  {
    [Property]
    private string email;
  }
}

All properties from A are available on B through inheritance and this code works:

B b = new B();
b.Id = 5;
b.Name = "Thomas";
b.Email = "Testmail";

Note that the code editor in Visual Studio might show errors where no errors exist. They still need to catch up a bit with editor support for source generators.

from mvvmgen.

thomasclaudiushuber avatar thomasclaudiushuber commented on May 24, 2024

Ok, reproduced. You're using the ModelType property of the attribute I guess to generate a ViewModel from a Model.

So, for the code below, the MyViewModel should have the properties Name and Email, but it has only an Email property.

public class BaseType
{
    public string? Name { get; set; }
}

public class SubType : BaseType
{
    public string? Email { get; set; }
}

[ViewModel(ModelType = typeof(SubType))]
public partial class MyViewModel
{

}

The generated output in MvvmGen version 1.1.2 is this, the Name property is missing:

// <auto-generated>
//   This code was generated for you by
//   ⚡ MvvmGen, a tool created by Thomas Claudius Huber (https://www.thomasclaudiushuber.com)
//   Generator version: 1.1.2
// </auto-generated>
using MvvmGen.Commands;
using MvvmGen.Events;
using MvvmGen.ViewModels;

namespace WpfApp2
{
    partial class MyViewModel : global::MvvmGen.ViewModels.ViewModelBase
    {
        public MyViewModel()
        {
            this.OnInitialize();
        }

        partial void OnInitialize();

        public string? Email
        {
            get => Model.Email;
            set
            {
                if (Model.Email != value)
                {
                    Model.Email = value;
                    OnPropertyChanged("Email");
                }
            }
        }

        protected WpfApp2.SubType Model { get; set; }
    }
}

from mvvmgen.

thomasclaudiushuber avatar thomasclaudiushuber commented on May 24, 2024

Thank you @khaledafifi for the issue. It's fixed and it will be part of an upcoming release.

from mvvmgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.