Possible issue with BIGINT primary keys?

[tjbanks]

Possible issue with BIGINT primary keys?

[tjbanks]

The following example also fails when trying to create the user. The only change from https://github.com/thomaxxl/safrs/blob/master/examples/mini_app.py is the biginteger primary key.

#!/usr/bin/env python
# run:
# $ FLASK_APP=mini_app flask run
from flask import Flask
from flask_sqlalchemy import SQLAlchemy
from safrs import SAFRSBase, SAFRSAPI

db = SQLAlchemy()

class User(SAFRSBase, db.Model):
    """
        description: User description
    """

    __tablename__ = "Users"
    id = db.Column(db.BigInteger(), primary_key=True)
    name = db.Column(db.String())
    email = db.Column(db.String())


def create_api(app, HOST="localhost", PORT=5000, API_PREFIX=""):
    api = SAFRSAPI(app, host=HOST, port=PORT, prefix=API_PREFIX)
    api.expose_object(User)
    user = User(name="test", email="[email protected]")
    print("Starting API: http://{}:{}/{}".format(HOST, PORT, API_PREFIX))


def create_app(config_filename=None, host="localhost"):
    app = Flask("demo_app")
    app.config.update(SQLALCHEMY_DATABASE_URI="sqlite://")
    db.init_app(app)
    with app.app_context():
        db.create_all()
        create_api(app, host)
    return app


host = "localhost"
app = create_app(host=host)

if __name__ == "__main__":
    app.run(host=host)

[thomaxxl]

Thanks for reporting this, I'll look into it tomorrow.

[thomaxxl]

Hi,

BigInteger doesn't have a default value (unlike db.Integer where the default value is set using the db engine autoincrement).

Does this work for you?

from flask import Flask
from flask_sqlalchemy import SQLAlchemy
from safrs import SAFRSBase, SAFRSAPI
from sqlalchemy.sql.expression import func

db = SQLAlchemy()

def my_default():
    return db.session.query(func.max(User.id)).scalar() + 1

class User(SAFRSBase, db.Model):
    """
        description: User description
    """

    __tablename__ = "Users"
    id = db.Column(db.BigInteger, primary_key=True, default=my_default)
    name = db.Column(db.String())
    email = db.Column(db.String())


def create_api(app, HOST="localhost", PORT=5000, API_PREFIX=""):
    api = SAFRSAPI(app, host=HOST, port=PORT, prefix=API_PREFIX)
    api.expose_object(User)
    user = User(name="test", email="[email protected]",id=0)
    print("Starting API: http://{}:{}/{}".format(HOST, PORT, API_PREFIX))


def create_app(config_filename=None, host="localhost"):
    app = Flask("demo_app")
    app.config.update(SQLALCHEMY_DATABASE_URI="sqlite://")
    db.init_app(app)
    with app.app_context():
        db.create_all()
        create_api(app, host)
    return app


host = "localhost"
app = create_app(host=host)

if __name__ == "__main__":
    app.run(host=host)

[thomaxxl]

Btw, there's an autoincrement parameter for db.Column constructors, but the actual implementation depends on the backend, it doesn't seem to work for sqlite (but maybe it does for psql).

Also, the id can also be added in the constructor instead of using the default parameter, for example:

def my_default():
    max_id = db.session.query(func.max(User.id)).scalar()
    if max_id is None:
        return 0
    return max_id + 1

class User(SAFRSBase, db.Model):
    """
        description: User description
    """

    def __init__(self, *args, **kwargs):
        kwargs['id'] = my_default()
        super().__init__(*args, **kwargs)

    __tablename__ = "Users"
    id = db.Column(db.BigInteger, primary_key=True)
    name = db.Column(db.String())
    email = db.Column(db.String())

[tjbanks]

@thomaxxl

Ah, this makes complete sense and will work perfectly! Sorry this ended up being an alchemy misunderstanding on my part rather than a SAFRS issue. Thanks for your explanation and time on this fantastic project!

@tjbanks