Giter Site home page Giter Site logo

Comments (3)

alexanderson1993 avatar alexanderson1993 commented on May 27, 2024

I hesitate to green light this since it would be a pretty breaking change for the way the station currently operates. We'd need to get buy-in from the individual space centers to make sure this doesn't affect their flow, or at very least have a configuration option where you can turn on this feature, and have it off by default.

from thorium.

Lilith-NightRose avatar Lilith-NightRose commented on May 27, 2024

Hmm. That makes sense. I'd definitely be totally open to implementing this as an entirely opt-in feature (probably part of the sim config). Is there a concern that even that could cause breaking changes?

I noticed that there exists a schema for "shortRangeCommExtended" in ./server/typedefs/shortRangeComm.ts. Is that currently being used, or would it work to use that schema as a sort of "second SR comms option"?

Finally, is this something I can hack around with now and expect to be able to relatively easily modify my solution to fit once the codebase has been reworked, or should I just hold off even approaching the issue until that process has been started?

from thorium.

alexanderson1993 avatar alexanderson1993 commented on May 27, 2024

Implementing it as an opt-in feature shouldn't introduce any breaking changes.

Looks like ShortRangeCommExtended isn't being used anywhere. I wouldn't use it for a "Second SR comms" - I think that's a bad plan. Any additions should be made to the ShortRangeComm GraphQL type.

Any new feature development can be made on the develop branch like normal. I think I'll do all of the Thorium 4.0 work in an entirely separate branch until it's time to release it. Any work done on the mainline branch will just be ported over eventually. So go ahead an implement it whenever you feel like.

from thorium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.