Giter Site home page Giter Site logo

Comments (4)

fridex avatar fridex commented on July 23, 2024 
---> Running application from script (app.sh) ...
2020-02-05 10:58:06,104   1 INFO     thoth.adviser:160: Version: 0.7.3
Usage: thoth-adviser advise [OPTIONS]
Try "thoth-adviser advise --help" for help.
Error: Invalid value for "--recommendation-type" / "-t": invalid choice: stable. (choose from STABLE, TESTING, LATEST)

Actually, this concrete issue looks like a bug in our openapi schema - user-api should validate input sent to endpoints, but it looks like we have not valid inputs:

https://github.com/thoth-station/user-api/blob/28a3ad7c9a46cf2612c034c06ab97f7c132c937d/openapi/openapi.yaml#L776-L778

The same might be true for requirements output (pip/pipenv vs PIP/PIPENV). Let's keep uppercase/lowercase consistent - so we eigher change adviser or openapi schema.

from qeb-hwt.

pacospace avatar pacospace commented on July 23, 2024 
---> Running application from script (app.sh) ...
2020-02-05 10:58:06,104   1 INFO     thoth.adviser:160: Version: 0.7.3
Usage: thoth-adviser advise [OPTIONS]
Try "thoth-adviser advise --help" for help.
Error: Invalid value for "--recommendation-type" / "-t": invalid choice: stable. (choose from STABLE, TESTING, LATEST)

Actually, this concrete issue looks like a bug in our openapi schema - user-api should validate input sent to endpoints, but it looks like we have not valid inputs:

https://github.com/thoth-station/user-api/blob/28a3ad7c9a46cf2612c034c06ab97f7c132c937d/openapi/openapi.yaml#L776-L778

The same might be true for requirements output (pip/pipenv vs PIP/PIPENV). Let's keep uppercase/lowercase consistent - so we eigher change adviser or openapi schema.

Perfect! Shall we change openapi enums to agree with adviser?

from qeb-hwt.

fridex avatar fridex commented on July 23, 2024 
---> Running application from script (app.sh) ...
2020-02-05 10:58:06,104   1 INFO     thoth.adviser:160: Version: 0.7.3
Usage: thoth-adviser advise [OPTIONS]
Try "thoth-adviser advise --help" for help.
Error: Invalid value for "--recommendation-type" / "-t": invalid choice: stable. (choose from STABLE, TESTING, LATEST)

Actually, this concrete issue looks like a bug in our openapi schema - user-api should validate input sent to endpoints, but it looks like we have not valid inputs:
https://github.com/thoth-station/user-api/blob/28a3ad7c9a46cf2612c034c06ab97f7c132c937d/openapi/openapi.yaml#L776-L778
The same might be true for requirements output (pip/pipenv vs PIP/PIPENV). Let's keep uppercase/lowercase consistent - so we eigher change adviser or openapi schema.

Perfect! Shall we change openapi enums to agree with adviser?

OK, sounds good to me 👍

from qeb-hwt.

pacospace avatar pacospace commented on July 23, 2024

This can be closed as @fridex took care of it.

from qeb-hwt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.