No numpy checklist

[thrameos]

No numpy checklist

[Thrameos]

• JArray must inherit from PyJPArray
• Remove numpy includes
• JPArray::GetSlice will return JArray instance
• JPArray::SetSlice must support sequence and memory view
• PyJPArray must support memory view
• Slice must replicate on Java call usage
• Slice must replicate on copy ctor
• Object arrays handle special
• JPArray must have start, stop, step,
• Backport PyJPArray from 0.8
• Rework getArrayRange
• Rework setArrayRange
• Clone on cast
• Slice assignment must be safe from self assignment
• Figure out how to extract data from struct API in C++
• Figure out how to get Python devs to respond regarding missing buffer API in the ABI
• Incorporate type conversion table for setSlice from buffers to support numpy
• Test getSlice against list with slices and compound slices
• Test setSlice from buffers
• Test getSlice to buffers

https://docs.python.org/3/c-api/typeobj.html#buffer-structs
https://docs.python.org/3/library/struct.html#module-struct

[Thrameos]

@marscher One big challenge on this is trying to match which rules array set slice should use. The closest equivalent I can find is

https://docs.scipy.org/doc/numpy/reference/generated/numpy.ndarray.astype.html

My best guess currently given the prior implementation is unsafe if sizes match otherwise no conversion as we dont appear to check the Python format codes. It only checks itemsize. This is mostly safe but does automatically turn floats to gibberish as a buggy side effect if you try to cast to int.

If I have to redo it then it needs to make some sense while not blatently replicating useless bugs. Java rules would require safe with same type (double to float) but they dont specify what to do with unsigned.
Thus i am guessing safe with same type plus automatic unsigned to signed on same size would be the most compatible to our current implementation and still not allow insane conversions (double to short)

Bool and char is also weird edge cases. The most permissive bool cases is anything that is not zero is true. That would seem like Python valid syntax, but not Java safe. Char has encoding requirements and like should not take buffer syntax at all.

Do you have any opinions on this?