Clang for Windows 3.5.0 fails at linking because of multiple definitions of setUp() and tearDown()

[zanedp]

Clang for Windows 3.5.0 fails at linking because of multiple definitions of setUp() and tearDown()

[mvandervoord]

I think both 1&2 are the way to go. We'll disable weak support for win32 (I wonder why the clang developers don't have all the features enabled for that platform?) for now. Then we can give an additional way to override the defaulted selection with either UNITY_INCLUDE_WEAK or UNITY_EXCLUDE_WEAK.

We've been evolving towards this standard of guessing as much as we can, and then giving the developer support to override those settings with include/exclude options.

If you're feeling up to tweaking one of your versions to do this, that would be awesome. Otherwise, just say so and I'll tackle it when I get some time.

Thanks so much!

Mark

[zanedp]

I'm not sure why Clang's not including the weak attributes in the object code. I verified using nm that when I compile with gcc on Windows, the weak attribute is output, but with both clang 3.5.0 and 3.6.0 SVN r223387 it is missing.

I've tried playing around with #pragma weak setUp etc, but that didn't help.

[zanedp]

Should Unity have an option to choose whether #pragma weak <symbol> is to be used vs __attribute__((weak)): UNITY_WEAK_PRAGMA vs UNITY_WEAK_ATTRIBUTE definitions to decide which syntax to use? For example, in unity.c:

#if defined(UNITY_WEAK_ATTRIBUTE)
    UNITY_WEAK_ATTRIBUTE void setUp(void) { }
    UNITY_WEAK_ATTRIBUTE void tearDown(void) { }
#elif defined(UNITY_WEAK_PRAGMA)
#   pragma weak setUp
    void setUp(void);
#   pragma weak tearDown
    void tearDown(void);
#else
    void setUp(void);
    void tearDown(void);
#endif

UNITY_WEAK_ATTRIBUTE could be set to __attribute__((weak)) for gcc and Clang or __weak for Keil.

[mvandervoord]

I've merged your patch. Thanks so much!