XRandr support

[tias]

XRandr support

[axet]

For how, when you try to run this utility on dual head machines X11 create Widget for booth screens which destroy all make callibration process.

for gtkmm build, it create right widget size, but incorrectly calculate X buttons positions. here an patch.

http://pastebin.com/bn2MZfr0

[axet]

https://bugzilla.gnome.org/show_bug.cgi?id=439588

[tias]

Hey Axet,

Thanks for the patch, it worked as expected on a dual-head system! I've commited the patch, but not yet pushed it. Can you give me a signed-off-by with your information, line along the lines of:
Signed-off-by: Tias Guns [email protected]
so that I can give you credit ?

About your last post: is this just extra information, or something that the code should be changed to ? It seems that the code as you proposed is fine.

BTW, I'm preparing a similar patch for the X11 GUI using the randr extention (http://www.xfree86.org/current/Xrandr.3.html)

Thanks a lot,
Tias

[axet]

Hey! No problem!

This is your code, and i have changed GPL code, so, it still yours, and still under GPL.

I'm not really understand why you need my details :)

Here is it:

Signed-off-by: Alexey Kuznetsov [email protected]

Last post, is an extra information. Just, some work around Xrandr for GTK. Like conformation, what my patch should work.

Good luck!

[tias]

Hey Alexey,

It is a way to give proper credit to who did what. You write the patch, so you are the author and that should be acknowledged right ?
Using git, when committing a patch, I can indicate who the author was.
For example, this is a patch that I created, and I'm the author and committer:
http://github.com/tias/xinput_calibrator/commit/42dc87f2ad6843a0998485bd2141984baee7f387
On the other hand, if you look at your patch:
http://github.com/tias/xinput_calibrator/commit/72f2482f4162c123b682ab74b6dc9eb296603258
then you can see that you are the author, and I am merely the committer.

This way, it also possible to trace back who exactly wrote what (for large projects like the kernel, this is very important).

In our case, I just want to properly acknowledge the work that you did : )

Kind regards,
Tias

[tias]

Worked a bit more on the change: added same for x11 gui and now explicitly checks whether the sizes changes during calibration (restarts calibration in that case).

Let me know if it doesn't work for you.
Ciao,
Tias