Giter Site home page Giter Site logo

Export `Stats(..)` about ekg-core HOT 3 OPEN

tibbe avatar tibbe commented on August 15, 2024
Export `Stats(..)`

from ekg-core.

Comments (3)

tibbe avatar tibbe commented on August 15, 2024

It's not exposed because I want to be able to change the implementation (e.g. to add support for quantiles). However, I am open to adding e.g. Binary instances or explicit decode/encode methods that could be used to transport stats over the network.

from ekg-core.

Fuuzetsu avatar Fuuzetsu commented on August 15, 2024

That would work too. I didn't see binary dependency (though it's probably a transitive one) so I assumed exposing constructor would be less of a change.

Generic and Typeable would be nice too while you're changing it (from base).

from ekg-core.

tibbe avatar tibbe commented on August 15, 2024

I think depending on binary is OK. If we don't want to commit to a specific library we could instead just offer:

encodeStats :: Stats -> ByteString
decodeStats :: ByteString -> Maybe Stats

This would allow us to change to use cereal or whatever in the future.

from ekg-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.