allowed_authentication_types not updated properly for install_shibboleth: true

[tibhannover]

allowed_authentication_types not updated properly for install_shibboleth: true

[mirjan-hoffmann]

@Edmondi-Kacaj How did you configure this on the internal Test-System? Also manually?

[Edmondi-Kacaj]

hello @mirjan-hoffmann

Yes shibboleth_after.yml just add a key

<entry key="allowed_authentication_types">shibboleth</entry>

and in the docker version, we don't need this, is added automatically by script inside the container,

in the .env file, you can find the variable below, and if this REPOSITORY_SERVICE_AUTH_EXTERNAL is true then it will add this property itself in homeApplication.properties.xml

# --- authentication service
REPOSITORY_SERVICE_AUTH=shibboleth
# --- use external authentication service
REPOSITORY_SERVICE_AUTH_EXTERNAL=true

so maybe we can comment for now this task in edu-sharing-config-file.yml

because we want to use the default configuration, but even if we leave it like it is it will be overridden by the script itself, based on .env variable

  
- include: ./common/shibboleth_after.yml
    shibboleth_after_path='{{repository_volume_config_cluster.stdout}}/applications'
  become: yes
  when: (edu_configure_shibboleth is defined and edu_configure_shibboleth) and
        (repository_volume_config_cluster.stdout is defined) and (repository_volume_config_cluster.stdout != "")
  tags:
    - edu-sharing-config
    - shibboleth

[mirjan-hoffmann]

@Edmondi-Kacaj Ok, then this is not a general problem of the adjustment of homeApplication.properties.xml - I'll rename the issue.

But the problem is still there. It is not working. If I set install_shibboleth: true, then <entry key="allowed_authentication_types">shibboleth</entry> is missing in homeApplication.properties.xml - this should be set automatically if shibboleth is activated (whichever way is used to configure this in edu-sharing v8)

[Edmondi-Kacaj]

Hello @mirjan-hoffmann

I created a pull request for this problem, can you have a look

[mirjan-hoffmann]

fixed with #46