Calculate should not use `mean` as the var name in output

[mine-cetinkaya-rundel]

Calculate should not use `mean` as the var name in output

[andrewpbray]

Hmm, good point. I'm inclined to agree that option 1 is preferable, but I would want to be sure that the stat is documented in the print method.

[andrewpbray]

Looking at calculate() right now, I think it'll make sense to abstract it a bit: create really only two if/thens - one for the single stat and one for the grouped stat (differences in props/means). This will make the code more concise, but also make it easier to extend for a generic FUN. I'll wait on that until Chisq and F are done to be sure that re-factoring makes sense.

[ismayc]

Option 1 sounds great! The note will be helpful too.

[rpruim]

This comment

Looking at calculate() right now, I think it'll make sense to abstract it a bit: create really only two if/thens - one for the single stat and one for the grouped stat (differences in props/means). This will make the code more concise, but also make it easier to extend for a generic FUN. I'll wait on that until Chisq and F are done to be sure that re-factoring makes sense.

seems to be in the wrong issue. I'd suggest opening a separate issue about this.

More importantly, isn't this the job of the stat function, not of calculate()? The fact that you have to extend things to work with a general function makes me worry that you are building a system that isn't really open at its core and will need a redesign after your initial experimentation.

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.