TO READ: Make guess-format() differentiate between %y and %Y

[tidyverse]

TO READ: Make guess-format() differentiate between %y and %Y

[garrettgman]

to self: % doesn't seem to work, but # does

[garrettgman]

also check if there is a time string on the end (which would screw up the # method)

[garrettgman]

maybe guess_format could spot time strings and select the correct year format by counting the number of characters in the date object?

[garrettgman]

guess_format() has been updated. If a user asks for ymd(x) when x also includes a time string, guess_format() will say that all failed to parse and prompt the user to look for missing or incorrect format elements.

Is this sufficient?
Do you want another function that will make a best determination of any possible format if the user has no clue?

[hadley]

That sounds ok to me.

[garrettgman]

Did you want me to make a helper function like ymdhms() for dates with time strings? I'm not sure what we decided at the last meeting (I didn't write it down or see it hear in the issues) :P

It would be difficult to test all the permutations of separators involved, but perhaps we could simplify it by using find_separators() to shorten the list. Or we could allow users to only use time stamps that end with 00:00:00, which seems usual (although sometimes seconds may have decimals). We could then shunt the last 8 characters into strptime and use ymd() on whatever is left over at the beginning.

Or as long as it has separators and is just numbers, we could

1. use find_separators() to identify separators
2. use strsplit to divide the datetime into its parts
3. use a slightly improved new_duration() to turn the datetime into a duration
4. add that duration to 0 AD to have a date and a time in POSIXt format.
5. we might have to make some adjustments for leap seconds, but the leap years will take care of themselves. I don't know about daylight savings

Should I work on this?
Should we have a function that would simply separate the date and time components of a date time?

[garrettgman]

ps. I like the review tab idea