Giter Site home page Giter Site logo

Comments (9)

hadley avatar hadley commented on June 12, 2024

This doesn't seem like the responsibility of tibble to me.

from tibble.

krlmlr avatar krlmlr commented on June 12, 2024

Doesn't this look odd to you:

> memdb_frame(a=1)
Source:   query [?? x 1]
Database: sqlite 3.11.1 [:memory:]

       a
   (dbl)
1      1
..   ...

On the other hand, it looks to me that this would be fairly difficult to fix in dplyr in an efficient way. Would it be permissible to soften "separation of concerns" in this case?

from tibble.

krlmlr avatar krlmlr commented on June 12, 2024

Should be fixed in dplyr.

from tibble.

hadley avatar hadley commented on June 12, 2024

It's a bit odd, but fixing it in general is going to be fiddly, and it doesn't crop up much during real data analysis.

from tibble.

krlmlr avatar krlmlr commented on June 12, 2024

Fiddling with it right now. Parts should be fixed in tibble (trunc_mat), parts in dplyr.

Can we split up dim_desc() and export format_dim(x)?

from tibble.

krlmlr avatar krlmlr commented on June 12, 2024

Now I have

> memdb_frame(a=1)
Source:   query [1 x 1]
Database: sqlite 3.11.1 [:memory:]

      a
  <dbl>
1     1

with generic dim_desc() and minor changes in dplyr.

This case occur in data analysis e.g. if you aggregate and have < 10 groups. I'd vote for reopening.

from tibble.

hadley avatar hadley commented on June 12, 2024

I'm willing to take a look, but I think making [1 x 1] work will break encapsulation

from tibble.

krlmlr avatar krlmlr commented on June 12, 2024

The relevant changes are #48 and krlmlr/dplyr@ae91470, works for me; I don't see where this breaks encapsulation.

from tibble.

github-actions avatar github-actions commented on June 12, 2024

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

from tibble.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.