The following program is not handled correctly

[timakin]

The following program is not handled correctly

[dcu]

another one:

package main

import (
	"net/http"
)

func main() {
	resp, _ := http.Get("https://example.com")
	defer func() {
		_ = resp.Body.Close()
	}()
}

[djui]

And another one:

resp, err := c.do(req)
if err != nil {
	return nil, err
}
defer func() { log.HandleError(resp.Body.Close()) }()

[timakin]

Thank you for your reports and I'm sorry for being late to supoort.
I'll fix them all.

[dcu]

thanks, and thanks for working on this I think it's really really really needed and will solve a very common issue, even in production

[timakin]

@dcu
Now I fixed all of them. And test cases below passed!
https://github.com/timakin/bodyclose/blob/master/passes/bodyclose/testdata/src/a/issue3.go

[djui]

I can't fully confirm that the fix addresses all items. I still see about 80% of false negatives on a repo of mine. One example:

resp, err := t.C.Do(req)
require.NoError(t, err)

defer func() { require.NoError(t, resp.Body.Close()) }()

It's the same pattern of my previous example, just a different wrapper function.

[dcu]

I created new issues for cases I found