Hashtable does not accept array objects containing XML document types as keys

[timdown]

Hashtable does not accept array objects containing XML document types as keys

[GoogleCodeExporter]

Thank you very much for this.

Re. problem 2, I'm not too worried about a poor quality hash being produced by 
the default hashing function. "[object XMLDocument]" is no worse than a regular 
object hashing to "[object Object]", which is what happens by default. So long 
as some hash is produced without possibility of an error being thrown and it's 
possible for client code to provide its own hashing mechanism, job done.

This leads onto problem 1, which is definitely a bug and needs to be dealt 
with. The simplest solution is to just drop the `obj.toString();` branch in 
`hashObject()`: it's redundant because your bug report proves `obj.toString();` 
needs either a try/catch or lengthy special handling, and `String(obj)` will 
check for and use a `toString()` method anyway.

Your `arrayToString()` is definitely useful for producing sensible hashes for 
arrays but I'd prefer to keep the file size as small as possible. You can still 
provide it as a hashing function in the Hashtable constructor. I've resisted 
the temptation to write general purpose hashing functions for that reason, 
preferring to leave sensible hashing completely up to client code.

I'll make the change and release a new version as soon as I can.

Original comment by [email protected] on 30 Sep 2011 at 12:26

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in new release.

Original comment by [email protected] on 16 Jul 2013 at 11:17

• Changed state: Fixed