Comments (3)
Hi, thanks for the report.
I can't reproduce this on my Mac (on the timely-dataflow
and diagnostics
master branch); are you on Linux?
from diagnostics.
Okay. I found the problem. I was using my own Cargo patch
version of timely-dataflow. I had extended the TimelyEvent
enum with my own variant. That seems to cause the locking behavior (even though I don't use the variant anywhere in the code...).
from diagnostics.
Right! Yes, the messages are encoded using https://github.com/TimelyDataflow/abomonation
, which is essentially just writing out the in-memory representation of rust objects. This means that even a minor difference in the definition of Event
s can cause things to break in unexpected ways.
If you need a custom event, you either need to change TimelyEvent
in both the timely program and in connect
(within diagnostics
) by changing its dependency to point to your custom timely
, or (maybe preferably) you can just register a separate event stream using something like https://github.com/TimelyDataflow/timely-dataflow/blob/4b4752ec7447253ac61c9804c9cf6406dabfc281/timely/examples/logging-send.rs#L21-L23
You can see how to make a receiver here: https://github.com/TimelyDataflow/diagnostics/blob/master/tdiag/src/commands/graph.rs#L51-L53
You can also customise how events are written out, by registering a different callback to the log_register
: this way you can emit, for example, bincode
or json
-encoded events. We use the binary abomonation
encoding because it's a lot faster than json
and, afaik, faster than bincode
(which is important for chatty logging streams like TimelyEvent
).
from diagnostics.
Related Issues (7)
- [differential arrangements] Support batch drop events HOT 1
- [graph] visualization to indicate where a dataflow is stuck HOT 3
- [graph] Subgraph names & operator names aren't shown
- This tool seems to be broken HOT 1
- [graph] Support filtering/collapsing of data flow regions to make huge graphs readable HOT 1
- Update to timely / differential 0.10 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from diagnostics.