Giter Site home page Giter Site logo

Comments (4)

timreichen avatar timreichen commented on May 29, 2024 1

#61 might fix the problem. But there are not tests atm that run cli.ts with args and flags. cli.ts needs a cli_test.ts file with cli tests to catch these kind of bugs.

from bundler.

rotu avatar rotu commented on May 29, 2024

I can also confirm this works correctly when invoked as either of:

deno run -A https://raw.githubusercontent.com/timreichen/Bundler/restructure/cli.ts bundle "file://C:\Users\dan\Desktop\test.html"
deno run -A https://raw.githubusercontent.com/timreichen/Bundler/restructure/cli.ts bundle "\\.\C:\Users\dan\Desktop\test.html"

from bundler.

timreichen avatar timreichen commented on May 29, 2024

I added an extra check for filepaths and status checks for windows. Can you check if it works now as expected on the main branch?

from bundler.

rotu avatar rotu commented on May 29, 2024

No dice. Did you check in your changes? The isURL function still returns true for Windows file paths, leading to the same improper fetch call.

from bundler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.