Non continuous video file produced.

[timscaffidi]

Non continuous video file produced.

[timscaffidi]

it is hard for me to say exactly without seeing your code, but It looks like you are sending either too much or too little information for each frame. For example you might be sending a 640x480 frame of pixels but the recorder is expecting 1024x768, or vise-versa.

[benjgorman]

I had this at the end of my setup method.

if(!vidRecorder.isInitialized())
{
vidRecorder.setup(fileName+ofGetTimestampString()+fileExt, ofGetWidth(), ofGetHeight(), 30); // no audio

}

Now I had the window mode set to fullscreen intitially and that gave me scanlines on the output, so I made it not full screen and I got the frames I already mentioned and then I set it to 640, 480 and I got more scanlines.

I was using this code in my update loop

ofImage img;
img.grabScreen(0, 0, ofGetWidth(), ofGetHeight());


vidRecorder.addFrame(img.getPixelsRef());

[timscaffidi]

I would advise against using ofGetWidth/Height with the video recorder as these values can change if you resize the window, and also I don't know that they will have the correct values if called within the setup function, as the window may not have been given its final size yet. Try hardcoding the width and height in both the setup method and within your update method, this should solve your problem.

I usually draw my entire scene to a FBO which has a fixed size (1920x1080 for example), then I can easily get the pixels from the FBO and save to the recorder. This has the added benefit of allowing me to draw the FBO to the screen at any size: should I need to support different resolution displays, just draw the FBO to fit within the window.

[benjgorman]

Aw man that worked perfectly! Great addon.

How would you do the FBO object?

[timscaffidi]

OF comes with an FBO example in the examples/gl/fboTrailsExample folder. If you need additional help with FBOs, make a topic in the OF forums and I'll be glad to look at it there.

[samelie]

Hi Tim, the addon works great with the videoGrabber, I have been struggling to get it recording from an FBO. This is what I get: gif

I'm modding the example trails you mentioned.
I allocate by ofPixels like so fboPix.allocate(640,480,OF_PIXELS_RGBA)
Then I do:
rgbaFbo.readToPixels(fboPix); vidRecorder.addFrame(fboPix);

I've made sure the videoRecorder.setup width/height matches. Could the pixel data
Would you be so kind as to updating the example with a working FBO version? I'm all out of ideas.

[kritzikratzi]

@samelie you should probably create a new bug. this seems non related.
anyways, try rgb, instead of rgba!

[timscaffidi]

@samelie , I believe @kritzikratzi is correct. Using RGBA for the FBO will not work because the video grabber is expecting RGB. The resulting gif you posted looks so strange because because you are sending 4 byte per pixel, and the video grabber is expecting 3.

[samelie]

fboPixels.allocate(fboWidth, fboHeight, OF_PIXELS_RGBA);
recorderPixels.allocate(fboWidth, fboHeight, OF_PIXELS_RGB);
fbo.readToPixels(fboPixels);
for (int i = 0; i < fboWidth * fboHeight; i++) {
int pix = i * 4;
int pixRgb = i * 3;
int r = fboPixels[pix];
int g = fboPixels[pix + 1];
int b = fboPixels[pix + 2];
recorderPixels[pixRgb] = r;
recorderPixels[pixRgb + 1] = g;
recorderPixels[pixRgb + 2] = b;
}
bool success = vidRecorder.addFrame(recorderPixels);

Ahha, nice one, my shader outputs RGBA! Thanks guys, works great!