Comments (5)
yes it appears those should be moved instead to be called in a function of the audio/video writer threads instead, since the file descriptors are no longer held by the main thread
from ofxvideorecorder.
I'm not sure I understand what you mean. Could you give more details?
from ofxvideorecorder.
Since the file descriptors moved to the writer threads, the main thead can't see them, so these calls are not going to do what is intended anymore. However, if the audio/video thread classes could have a public method that calls setNonblocking on their internal file descriptors, these new functions could be invoked in the same place as the current calls.
from ofxvideorecorder.
ok I see. I can look in to that later. But what does that mean for the current version of the addon. Could these 'broken' calls be the source of issues at runtime?
from ofxvideorecorder.
They may have caused problems, but I haven't had time to adequately test. Thanks for the fix!
from ofxvideorecorder.
Related Issues (20)
- Add iOS support HOT 2
- App OF submitted to the problems encountered in Mac Store
- What the problem is ? HOT 1
- write to PIPE failed with error -> 32 - Broken pipe HOT 4
- For some reason, Ubuntu no longer switches threads for me... HOT 20
- Can I record OF output HOT 1
- Add no audio option HOT 1
- pixelFormat = "rgba" HOT 7
- No audio on Windows using branch osx-and-win HOT 5
- c930
- Ambiguous function name + example needed HOT 1
- can not open the recorded video file in recordingComplete function HOT 6
- Video recording issue - scrambled images HOT 4
- Files not being saved HOT 1
- Problems saving in a specific folder HOT 4
- Audio recording: system exception: cannot lock mutex
- Support for OF 0.10.0 HOT 3
- Windows VS2017, 0.10 master branch, added Poco but error about <unistd.h> HOT 2
- Trying to use this addon HOT 1
- ofxVideoRecorder seems to fail when the path to app (and ffmpeg) has spaces in it HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ofxvideorecorder.