Make TFTP session timeout tunable (defaults to 3 seconds)

[lukaskalvenas]

Make TFTP session timeout tunable (defaults to 3 seconds)

[gianarb]

Just sharing what I discovered. We use a lib called betawaffle/tftp-go. It serves a UDP server with a handler that implements TFTP. From my understanding, the timeout can't be changed:

https://github.com/betawaffle/tftp-go/blob/master/server.go#L164

serve() does not accept a timeout and its value is set by default to 3s. @mmlb can you confirm or deny? I feel a bit lost :)

[mmlb]

all true. I've been wanting to either fork that repo and make some changes for a while now or look into an alternative. This may be the time to do so... probably the fork ;).

[gianarb]

@mmlb apparently we have a fork now

https://github.com/tinkerbell/tftp-go

I think @mikemrm did that, can we update that fork and fix this issue?

[jacobweinstock]

iPXE binaries served via tftp now have a configurable timeout. please see: https://github.com/tinkerbell/boots/blob/5faab799ed5c1ceea501df7b3768effbbd7261ed/cmd/boots/main.go#L401