Giter Site home page Giter Site logo

Comments (10)

deadprogram avatar deadprogram commented on May 9, 2024

Is this still a problem? Also is it specific to WASM?

from tinygo.

aykevl avatar aykevl commented on May 9, 2024

It is not specific to WebAssembly, but you wouldn't generally notice it otherwise.
I hope it is gone after #89 but I'm not entirely sure, I haven't tested this.

from tinygo.

deadprogram avatar deadprogram commented on May 9, 2024

Has this issue been correct in master branch @j7b can you please verify? Thanks.

from tinygo.

aykevl avatar aykevl commented on May 9, 2024

Most likely not, I didn't touch that code (and I've seen the issue myself recently).

from tinygo.

niaow avatar niaow commented on May 9, 2024

What is the intended behavior here? Right now, when building, it compiles and the linker just complains about the symbol not being found.

from tinygo.

aykevl avatar aykevl commented on May 9, 2024

It would be nice to name the main package main, so you have the symbol main.main. This is what the Go toolchain does. I haven't seen a direct need for this, however.

from tinygo.

niaow avatar niaow commented on May 9, 2024

Okay I guess I just misunderstood the issue.

from tinygo.

deadprogram avatar deadprogram commented on May 9, 2024

OK I must be missing something here: https://play.golang.org/p/jqxNrK9fi_R

The output of the submitted test program does not work on the normal Go Playground either:

./prog.go:3:6: missing function body

Go build failed.

I feel like for the first time I am questioning what exactly this issue is about? Can anyone please clarify? Thank you.

from tinygo.

niaow avatar niaow commented on May 9, 2024

This now seems to produce the expected name.

The output of the submitted test program does not work on the normal Go Playground either:

The standard Go implementation requires an assembly file to be included in the package to allow this.

It would probably be more correct for this to use //export or similar though.

from tinygo.

dgryski avatar dgryski commented on May 9, 2024

Agree. This is fixed I'm pretty sure.

~/go/src/github.com/dgryski/bug $ tinygo build -target wasm -o withdot.ll .
~/go/src/github.com/dgryski/bug $ grep 'declare i32.*x.*local_unnamed' withdot.ll
declare i32 @main.x(ptr) local_unnamed_addr #2

from tinygo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.