Comments (5)
Super cool! > R
We create default material when there's no .mtl, so this should be an expected behaviour.
But it may be nice we have materialFound
flag somewhere?
from tinyobjloader.
Thanks for quick response! I think it would be good to indicate that the material file has not been found, but I think you are saying that this should not be an error (because we might want to be able to open an obj file even if the material file is missing).
from tinyobjloader.
Okay, I'll consider to add some flag > I think it would be good to indicate that the material file has not been found
from tinyobjloader.
Now in addition, I noticed this because the default material can have some strange values. It seems that
InitMaterial(material);
is never called in this case because it is inside the read loop (see https://github.com/syoyo/tinyobjloader/blob/master/tiny_obj_loader.cc#L421-L462). So should it not be placed right after?
material_t material;
Finally, I noticed the strange values only from R, not running test_loader, so perhaps different compiler flags are resulting in default initialisation in some cases but not others. I am using Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
. Thanks again!
from tinyobjloader.
Good catch! > strange values.
Add fix for InitMaterial and add warning message to err
. Strictly say, its warning, but would be ok to store warning message in err
, since this does not change any API interface.
from tinyobjloader.
Related Issues (20)
- How to use tinyobjloader with CMake on OSX HOT 2
- pkg-config file is broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute HOT 1
- How to package tinyobjloader? HOT 2
- LoadObj fails to load materials while reader object succeeds HOT 1
- Normal indices with a value of zero HOT 4
- All vertex color data is (1,1,1) HOT 1
- Adding my project to Use Case section HOT 2
- mtllib filename with spaces HOT 2
- material name with leading whitespaces are not supported HOT 3
- I am getting texcoord_index = -1 for some models? HOT 2
- I just need index buffer HOT 1
- Material specification link in README is outdated HOT 3
- Some textues are appeared in 180 degree rotated HOT 1
- A small fault in loader_example.cc HOT 1
- when using default materials at least keep the material id
- Facets with > 255 vertices HOT 2
- New release 1.0.7? HOT 1
- How to get the material names without a .mtl? HOT 1
- The problem of parsing the texture coordinates is incorrect when using the library
- Deduplicate vertex
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tinyobjloader.