Giter Site home page Giter Site logo

Comments (13)

rbaghdadi avatar rbaghdadi commented on May 22, 2024 1

Ok, here is the solution then:

  • Compile a fresh Halide as described in the Halide github page: https://github.com/halide/Halide (you do not need to compiler LLVM from sources)
  • Then use that Halide to compile Tiramisu. You need only to edit the two lines here:
    set(HALIDE_SOURCE_DIRECTORY "3rdParty/Halide")

    to point to your new Halide.

In principle, if you get a fresh Halide from the halide repo, that one is good. The Halide that we have is a bit old and does not have the fix to avoid the problem you specified.

from tiramisu.

rbaghdadi avatar rbaghdadi commented on May 22, 2024 1

Ok this is perfect! So if I understood well, you problem is solved now?

You want to patch the old Halide or the new one?

from tiramisu.

rbaghdadi avatar rbaghdadi commented on May 22, 2024

Hi @kazimuth , yes indeed. If we use the new Halide (and not our fork of Halide which is a bit old), that would solve the problem. On one of our internal machines, Tiramisu works fine with a new Halide, but I just did not have time to propagate the change to CI.

If you are interested in helping on that I can give you assistance and we can try.

from tiramisu.

kazimuth avatar kazimuth commented on May 22, 2024

I might be able to pick that up, sure. I'm contemplating using Tiramisu for some MIT coursework this semester, but to do that I'll need a functioning build on my machine :)

from tiramisu.

rbaghdadi avatar rbaghdadi commented on May 22, 2024

Oh Ok I see. That one is independent though. You should be able to compile and use Tiramisu without a problem. The problem that we have with CI is only related to a mismatch in the LLVM versions we are using or something. There is a PR that tries to address that, but I still didn't have time to test it.

Go ahead and just install Tiramisu on your machine and let us know if you have a problem. If you get a problem I'll be happy to help you out.

from tiramisu.

kazimuth avatar kazimuth commented on May 22, 2024

Yeah, I was running into the same problem cause I was trying to avoid recompiling LLVM lol.

Will do.

from tiramisu.

rbaghdadi avatar rbaghdadi commented on May 22, 2024

Let me know if this works for you.

from tiramisu.

kazimuth avatar kazimuth commented on May 22, 2024

Compiling old LLVM and halide works fine.

Using current halide gives a few compile errors; they seem fixable, though. I might take a shot at patching them over the weekend.

from tiramisu.

kazimuth avatar kazimuth commented on May 22, 2024

I think it would be possible to just patch tiramisu to use the new halide. Most of the changes seem to be small changes to function signatures, unless there have been any major underlying architecture changes in Halide I'm not seeing.

from tiramisu.

rbaghdadi avatar rbaghdadi commented on May 22, 2024

In theory, even Tiramisu should not be modified. It should work with the new Halide without a change. Only the github submodule pointer has to point to the public halide instead of pointing to the current outdated Halide. I have tried before to make it work with the new Halide and it just worked with the need to change Tiramisu so it should be fine! (unless I'm missing something)

from tiramisu.

kazimuth avatar kazimuth commented on May 22, 2024

Hm, there seem to be some compilation errors? Changed signatures and stuff, with the most recent halide release.

from tiramisu.

rbaghdadi avatar rbaghdadi commented on May 22, 2024

from tiramisu.

mratsim avatar mratsim commented on May 22, 2024

Are there new errors compared to those I reported? #217 (note that I didn't try to build Tiramisu with Halide master)

from tiramisu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.