Loading commander gem in a Rails 4 environment triggers: "DEPRECATION WARNING: RAILS_CACHE is deprecated!"

[tj]

Loading commander gem in a Rails 4 environment triggers: "DEPRECATION WARNING: RAILS_CACHE is deprecated!"

[ggilder]

Hmm. It doesn't seem like calling introspection methods like is_a? and respond_to? should trigger the deprecation warning, but maybe it's just applied to all methods.

[mattbrictson]

Yes, the deprecation warning seems to be triggered on all methods except inspect. For example, respond_to?:

>> ::RAILS_CACHE.respond_to?(:parse)
DEPRECATION WARNING: RAILS_CACHE is deprecated! Use ::Rails.cache instead. (called from irb_binding at (irb):1)
=> false

Here is the basic implementation from activesupport:

class DeprecationProxy #:nodoc:
  def self.new(*args, &block)
    object = args.first

    return object unless object
    super
  end

  instance_methods.each { |m| undef_method m unless m =~ /^__|^object_id$/ }

  # Don't give a deprecation warning on inspect since test/unit and error
  # logs rely on it for diagnostics.
  def inspect
    target.inspect
  end

  private
    def method_missing(called, *args, &block)
      warn caller, called, args
      target.__send__(called, *args, &block)
    end
end

Should commander work around this, or do you think I should raise this as an issue with activesupport?

[ggilder]

@mbrictson could you try this commit and confirm if it fixes the problem? It works for me. b475b6e

[mattbrictson]

Yes, that fixes the deprecation warning for me. Thanks!

[ggilder]

Cool, I've just released 4.1.5 with this fix incorporated.