Remove Build System?

[hyperupcall]

Remove Build System?

[spacewander]

To solve #1058, we can use a directory under /tmp as the $PREFIX and install the script during test, or run the test in a docker container.
To be frank, I wouldn't say I like to change the project structure as it can be solved by the test suite itself.

[hyperupcall]

@spacewander Yes, more code could be added to the test suite to handle this. But, what about the other issues I have mentioned? Complexity/fragility of the build system and difficulty of using common functions. The test suite isn't the only place where we see the problems from the build system

[spacewander]

here is a common util.sh file (that we can place in /usr/share/git-extras) that contains all our shared functions. Executables that require it can source it first-thing

As there is no common utility directory for all unix system (Linux, Mac, BSD), and the user can specify the root by using $PREFIX, move them to a separate file and source it during execution may break the portability and make it harder to manage.

We manually copy and paste these functions for every file. BUT, each function is prefixed with a common prefix (like util_, common_), and we have a check (run at build time and/or commit time) to make sure each function and its contents are identical. Making changes to these functions still isn't too hard because one can simply do a repository-wide find-and-replace in their favorite IDE

The current build process is already guaranteeing the consistency of the utility. To be frank, the check and the find-and-replace could be also complex & fragile.

[hyperupcall]

I see and understand where you are coming from - there are some disadvantages to my approach as well like the $PREFIX and moving bin/ files like you mentioned. Thank you for clarrifying your position. Although I may disagree, I will close this issue since you prefer the current approach.