Dura fails to capture anything if a worktree is present as a subdir of the working directory

[tkellogg]

Dura fails to capture anything if a worktree is present as a subdir of the working directory

[DeeUnderscore]

It seems to be an issue with git2. A minimal example that reproduces this is:

use git2::{Repository, IndexAddOption};

fn main() {
    let repo = Repository::open("./").unwrap();
    let mut index = repo.index().unwrap();
    index.add_all(["*"].iter(), IndexAddOption::DEFAULT, None).unwrap();
}

I'm not sure if the git2/libgit2 behavior here is a bug. Git itself when asked to git add -A in this situation adds the repository as a subproject link and prints a hint about adding it as a submodule instead.

[dswij]

This is a git2-rs behaviour which returns Result::Err when adding another git repo inside a subdirectory.

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { code: -1, klass: 10, message: "invalid path: 'foo-git/'" }', src/main.rs:6:64
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Not sure if the preferred behaviour for dura would be ignoring these paths or adding them into consideration for checking the diff. Personally, I'd probably ask dura to watch the repos in subdirectory separately.

[tkellogg]

Thanks for reporting. I don't have much time to look at it this weekend, but I might next week. I'm not quite sure what's going on.

[JakeStanger]

The ideal scenario I guess would be a include_sub_repos setting (or something to that effect) so you can toggle it. I think that should default to false.

I'd probably ask dura to watch the repos in subdirectory separately

Do you think using the existing include option would be a good way of doing this, or would that risk confusion? Would it be safer to just stick to adding an entire new repo entry in the config?