Smelting Data

[tktech]

Smelting Data

[Pokechu22]

Currently, recipes other than minecraft:crafting_shaped and minecraft:crafting_shapeless are ignored:

https://github.com/mcdevs/Burger/blob/fdff962aeb1aa0351fc222e005af3fa9248345fb/burger/toppings/recipes.py#L135-L137

It wouldn't be that hard to add them (for versions that use JSON-based smelting recipes at least), but I'm also not sure how useful that information would be to include (especially since the smoker and blast furnace also exist and have mostly redundant data, and then there's other devices as well...)

[njt1982]

Oh... This would do it...

https://github.com/mcdevs/Burger/blob/fdff962aeb1aa0351fc222e005af3fa9248345fb/burger/toppings/recipes.py#L136

Why don't we care about those?

[njt1982]

@Pokechu22 Thanks for the response.

So for my needs (some context), the lack of furnace data in the downstream https://github.com/PrismarineJS/minecraft-data package due to it being excluded here means my little browser app has no data for iron_ore (amongst the rest of the list above).

https://njt1982.github.io/minecraft-item-browser/#/iron_ore

Would you bundle this data into recipes.json or would you put it in its own topping?

[Pokechu22]

For burger, if I did include it, it would be in the same recipes section (burger only generates one JSON file), since I'd want to process it in the same recipes topping (since that handles the other JSON recipes). About 40% of the current burger JSON files are recipe data, and adding more data to it seems a bit overkill (given that there isn't really much of a processing step to it; it's just taking data already in JSON and expanding tags).

It might be easier for minecraft-data to use the data generator system (or directly extracting the JSON files from the minecart jar) themselves, and bundle it into their own recipes.json or equivalent, rather than that data first being put into burger and then put into minecraft-data.