Comments (7)
If there are enough approvals, but not everyone who requested changes approved, set the minimum time to 4 days.
Maybe that should be extended to 7 days, because we're not always that active...
from tldr-bot.
Maybe we could even add a custom reminder for specific cases, like
@tldr-bot remind in 3 days
from tldr-bot.
Sure. I'd love to do this myself, but if it's more advanced than Hello World
I'll probably fail miserably 😆.
Does everyone agree with the ruleset for this new action?
from tldr-bot.
We only get notifications from tldr-bot after a month, which is a pretty long time to leave a finished PR unmerged.
from tldr-bot.
Yeah, I'd suggest if a PR has enough approvals and and is idle for at least 2 days then tldr-bot posts a single reminder. If someone has requested changes and has yet to approve, wait 7 days before reminding.
Currently GitHub actions should notify on 14 days, and then auto-close at 30 days.
from tldr-bot.
Sounds good! We could absolutely implement this. It could maybe scan all open PRs every 24 hours?
from tldr-bot.
Isn't this covered by the stale flow?
from tldr-bot.
Related Issues (7)
- proposal: /commands (set-more-info-link in particular) HOT 4
- Improve readability of error report messages HOT 3
- Add link to this repo in the tldr-bot's user profile HOT 1
- Change icon/profile pic of the tldr-bot HOT 3
- Get tldr-bot marked as a bot account? HOT 1
- Use a package management tool to capture dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tldr-bot.