Giter Site home page Giter Site logo

Comments (7)

bl-ue avatar bl-ue commented on May 24, 2024 2

If there are enough approvals, but not everyone who requested changes approved, set the minimum time to 4 days.

Maybe that should be extended to 7 days, because we're not always that active...

from tldr-bot.

marchersimon avatar marchersimon commented on May 24, 2024 2

Maybe we could even add a custom reminder for specific cases, like

@tldr-bot remind in 3 days

from tldr-bot.

marchersimon avatar marchersimon commented on May 24, 2024 1

Sure. I'd love to do this myself, but if it's more advanced than Hello World I'll probably fail miserably 😆.

Does everyone agree with the ruleset for this new action?

from tldr-bot.

marchersimon avatar marchersimon commented on May 24, 2024 1

We only get notifications from tldr-bot after a month, which is a pretty long time to leave a finished PR unmerged.

from tldr-bot.

sbrl avatar sbrl commented on May 24, 2024 1

Yeah, I'd suggest if a PR has enough approvals and and is idle for at least 2 days then tldr-bot posts a single reminder. If someone has requested changes and has yet to approve, wait 7 days before reminding.

Currently GitHub actions should notify on 14 days, and then auto-close at 30 days.

from tldr-bot.

sbrl avatar sbrl commented on May 24, 2024

Sounds good! We could absolutely implement this. It could maybe scan all open PRs every 24 hours?

from tldr-bot.

waldyrious avatar waldyrious commented on May 24, 2024

Isn't this covered by the stale flow?

from tldr-bot.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.