Giter Site home page Giter Site logo

Comments (3)

valfrid-ly avatar valfrid-ly commented on July 16, 2024

Except for changing

AllColumns = GetColumns().ToList();
AllColumns = AllColumns.Select(c => new ColumnAllColumns = GetColumns().Select(c => new Column

for

AllColumns = GetColumns().Select(c => new Column

I see no difference in your code that justifies any change in the key

from dapper-extensions.

ellenfier avatar ellenfier commented on July 16, 2024

Well, I use a local variable 'allColumns' instead of AllColumns and a ConcurrentDictionary to keep the columns value.

var allColumns = GetColumns().Select(c => new Column()).ToList(); // or _dictionary[classMapper]
//AllColumns = GetColumns().ToList();
//******
AllColumns = allColumns;

The method 'DapperImplementor.GetSimpleAliasFromColumnAlias(string columnAlias)' will return the value of SimpleAlias. And if it is null or empty, the key of DynamicParameter will be the PropertyInfo.Name instead of SimpleAlias.
When the method GetSimpleAliasFromColumnAlias is invoked by a thread, and at the same time AllColumns = GetColumns().ToList() is invoked by another thread, the problem happens. It's now thread safe.

I also change the method GetSimpleAliasFromColumnAlias.
like
SqlGenerator.GetColumnsByClassMapper(prop.ClassMapper).Any(c => c.Alias.Equals....

from dapper-extensions.

valfrid-ly avatar valfrid-ly commented on July 16, 2024

Would you be able to send a PR with your changes??

Please, don't forget to update the unit tests too.

from dapper-extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.