millis overflow bug

[tobiasschuerg]

millis overflow bug

[gerritzen]

I would like to suggest removing isReady() completely or at least make it an option one can disable. Is it possible that the line in the data sheet was misinterpreted?

T_{90} < 120s does not mean one can only read the sensor every 120 seconds. If you suddenly expose the sensor to a new atmosphere, it takes less than 120 seconds to cover 90% of the difference. So if you go from 400ppm to 800ppm, after 120 seconds the sensor should report at least 760ppm. That is not a reason to prevent the library from reading it out earlier anyway.

Since the response time is a physical property of the sensor, it should be handled regardless of readout channel. Currently, it is checked for UART and the check is commented out for PWM.

[MattMills]

Agreed, I was just looking at this code with confusion trying to see why UART only reported readings occasionally, I removed all the weird response time stuff from isReady() and it works fine now.

[wer-is-paul]

Check my Pull Request where i tried to tackle this

[SNMetamorph]

Fixed in 1.4.1 version, may be close it?

[tobiasschuerg]

Thanks for the reminder :-)