Comments (16)
This is quite a big change. We'll need to add an setting to the options page that records your domain name so we can detect that page. We'll need to add a new code block that will be triggered and figure out the correct board/card names to pass to the plugin.
If you want to contribute then I can help you find the correct locations to alter the code but I don't have a Next cloud deck to test/dev against, so I'd not really be able to work on this ATM.
I'll keep this open as adding more clients does seem like a good idea.
from chromekimaibridge.
Great. I'll try to add my contribution soon. I wanted to make sure you were interested in developing the plugin. You're right to add domain information to the settings. Thank you.
p.s. Sorry if my English isn't so good.
from chromekimaibridge.
No worries about the English.
I'll create a branch and stub up some pseudo code, give me a little time.
from chromekimaibridge.
Can you supply me with a sample URL from a Nextcloud deck 'card' please?
I'm thinking about adding support for domain/reg ex to get the card id's
from chromekimaibridge.
Please see your email
from chromekimaibridge.
Hello @tobybatch
Did you have time to see the nextcloud deck?
Have a nice day.
from chromekimaibridge.
Yes, thanks. I'll think about how I patch the plugin.
from chromekimaibridge.
@krestyanikov Can you take alook at the branch 9-add-support-for-extra-services
You'll need to pull the repo and checkout the new branch and replace the chrome extension but I've added a settings page on /chrome/settings that lest you add host names and regex's to enable any host.
from chromekimaibridge.
Hello @tobybatch , your regex idea is amazing!
I have experienced some difficulties, but it works! I will not create a commit, but I will describe it right here with your permission.
At first I tried it, but I got a mistake
[2020-08-07 12:25:14] php.CRITICAL: Uncaught Error: Argument 1 passed to KimaiPlugin\ChromePluginBundle\Entity\SettingEntity::setRegex2() must be of the type string, null given, called in /home/krestya5/public_html/kimai2/var/plugins/ChromePluginBundle/Controller/ChromeController.php on line 467 {"exception":"[object] (TypeError(code: 0): Argument 1 passed to KimaiPlugin\ChromePluginBundle\Entity\SettingEntity::setRegex2() must be of the type string, null given, called in /home/krestya5/public_html/kimai2/var/plugins/ChromePluginBundle/Controller/ChromeController.php on line 467 at /home/krestya5/public_html/kimai2/var/plugins/ChromePluginBundle/Entity/SettingEntity.php:60)"} []
I easily fixed it
Next, when I tried to transfer a link from the plugin, I found that it was interrupted on the Score symbol
had to encode the URL in the plugin
The link was received correctly, but only the board code was transmitted
/index.php/apps/deck/#/board/14/card/133
Returning board id=14, card id= [] []
for some reason $matches[1] was not obtained through regex.
I used the following settings and it worked!
Returning board id=14, card id=133 [] []
Thank you very much for your work! There are some other problems that I've discovered. I'll describe them in other Issues
from chromekimaibridge.
Can you try pulling the latest version, on branch 9-add-support-for-extra-services
There is now a test button next to the config entry that should allow you to run a test URI through the service that parses the URL
from chromekimaibridge.
Hello @tobybatch
I checked for changes. I noticed a couple of problems
- The return of two variables does not work. I changed it.
- When testing, there is no way to leave the field blank.
if I insert an empty value into Regex2, I get an error.
Have a nice day.
from chromekimaibridge.
@krestyanikov Sorry for the delay, I've been away for a bit. Back now, I'll take a look this week.
from chromekimaibridge.
@krestyanikov I'm back with another (better) iteration that seems to work for me. Again you'll need to pull the 9-add-support-for-extra-services branch in the var/plugin/ChromePluginBundle and reload the crx that's in that branch.
I think this should work with nextcloud deck.
from chromekimaibridge.
Hello @tobybatch
It works fine! You will get more stars and feedback when we start using the plugin in production.
I noticed a slight inaccuracy, but I'm not sure if it's an error.
In the list of time entries, the description is activity, but the description entries are not displayed
I also have other suggestions that I will publish separately.
p.s. do You have a donation channel?
Thanks!
from chromekimaibridge.
Hello @tobybatch
Can you install a new version of the plugin in the chrome store?
Have a nice day.
from chromekimaibridge.
Hi @krestyanikov I'll get on this asap. I need to be careful that I keep backward compatibility though. I'll put some time in to this soon.
from chromekimaibridge.
Related Issues (14)
- Internationalizing chrome plugin HOT 1
- External Card/project link and goto button HOT 1
- Refactor as a react app
- unexpected TimesheetService HOT 6
- Error while reloading after cloning plugin HOT 2
- Add compatibility to 2.0.27 HOT 2
- Only enable on trello.com and github.com HOT 1
- Options page should close after saving
- Log time page should close popup after time is submitted
- Firefox !
- Try and load js libs from kimai
- Better detection of remote kimai instance
- ChromePlugin Card ID question HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chromekimaibridge.